Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The implementation of dynamic batch loading code seems inconsistent with the pseudo-code in the paper #42

Open
YWMditto opened this issue Dec 25, 2023 · 1 comment

Comments

@YWMditto
Copy link

For example, truncating the loss difference to 0 does not seem to be implemented.
image

diff = torch.tensor(losses) - torch.tensor(self.target_loss)

And, what is the purpose of this line?

updated_domain_weights = (1-c) * updated_alpha + c / self.n_domains

@xiamengzhou
Copy link
Contributor

Hi, sorry for the late reply!

In the implementation, we added a small uniform proportion (c=1e-4/7) to each domain when updating the weights. It's simply a smoothing factor, and does not in practice affect results much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants