Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusts conditions to rigger coordinate function #324

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

glamperd
Copy link
Contributor

@glamperd glamperd commented Sep 2, 2024


name: Avoid status change that halts ceremony. see #319 #323
about: Open a PR for p0tion

Description

In rare circumstances, a contribution updates its status such that the move from one circuit to the next is not triggered. The effect is that the circuit queue freezes until manually cleared.

Fixes # (issue)
The conditions that are tested to trigger the coordinateCeremonyParticiapnt command were adjusted so that any change from a non-complete status/step to completed will trigger the coordinate function and clean up the circuit correctly.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] Any dependent changes have been merged and published in downstream modules
  • [ x] I reviewed the code of conduct and contributors' guide

@glamperd glamperd merged commit 7045762 into dev Sep 2, 2024
1 of 2 checks passed
@glamperd glamperd deleted the fix-currentContributor-bug branch September 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant