Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Precompile: 0x05 modexp #322

Open
ChihChengLiang opened this issue Nov 23, 2022 · 6 comments
Open

Precompile: 0x05 modexp #322

ChihChengLiang opened this issue Nov 23, 2022 · 6 comments
Assignees

Comments

@ChihChengLiang
Copy link
Collaborator

No description provided.

@ChihChengLiang
Copy link
Collaborator Author

Scroll has an on going implementation

scroll-tech/zkevm-circuits#520

@KimiWu123 KimiWu123 added this to the Feature Completeness milestone Oct 19, 2023
@KimiWu123 KimiWu123 moved this from 🆕 Product Backlog Items to 🏗 In progress in zkEVM Community Edition Oct 23, 2023
@KimiWu123 KimiWu123 self-assigned this Oct 23, 2023
@KimiWu123 KimiWu123 moved this from 🏗 In progress to 📋 Sprint Focus in zkEVM Community Edition Oct 23, 2023
@KimiWu123 KimiWu123 removed their assignment Oct 23, 2023
@KimiWu123 KimiWu123 moved this from 📋 Sprint Focus to 🏗 In progress in zkEVM Community Edition Oct 24, 2023
@KimiWu123 KimiWu123 self-assigned this Oct 24, 2023
@KimiWu123 KimiWu123 moved this from 🏗 In progress to 📋 Sprint Focus in zkEVM Community Edition Oct 24, 2023
@KimiWu123 KimiWu123 removed their assignment Oct 24, 2023
@KimiWu123 KimiWu123 moved this from 📋 Sprint Focus to Milestone Tasks in zkEVM Community Edition Nov 26, 2023
@adria0
Copy link
Member

adria0 commented Jan 29, 2024

It seems that Scroll MODEXP precompile is not exactly the same than Ethereum Mainnet.
https://docs.scroll.io/en/technology/chain/differences/#precompiled-contracts

image

@lispc
Copy link
Collaborator

lispc commented Jan 29, 2024

yes..

It seems that Scroll MODEXP precompile is not exactly the same than Ethereum Mainnet. https://docs.scroll.io/en/technology/chain/differences/#precompiled-contracts

image

yes.. may not suitable for a type1 zkevm

@adria0
Copy link
Member

adria0 commented Jan 29, 2024

yes..

It seems that Scroll MODEXP precompile is not exactly the same than Ethereum Mainnet. https://docs.scroll.io/en/technology/chain/differences/#precompiled-contracts
image

yes.. may not suitable for a type1 zkevm

Any plan, for the moment, to release a Type-1 MODEXP @lispc ?

@lispc
Copy link
Collaborator

lispc commented Jan 29, 2024

yes..

It seems that Scroll MODEXP precompile is not exactly the same than Ethereum Mainnet. https://docs.scroll.io/en/technology/chain/differences/#precompiled-contracts
image

yes.. may not suitable for a type1 zkevm

Any plan, for the moment, to release a Type-1 MODEXP @lispc ?

Maybe not within a foreseeable future. We collected usage of modexp from mainnet, and found most (maybe all..) of them are U256 input. Supporting only u256 is simpler, so we chose to support only u256.

@KimiWu123 KimiWu123 moved this from Milestone Tasks to 🏗 In progress in zkEVM Community Edition Jan 29, 2024
@ed255 ed255 unassigned adria0 Feb 8, 2024
@ed255 ed255 moved this from 🏗 In progress to Milestone Tasks in zkEVM Community Edition Feb 8, 2024
@ed255 ed255 moved this from Milestone Tasks to 📋 Sprint Focus in zkEVM Community Edition Feb 8, 2024
@adria0
Copy link
Member

adria0 commented Feb 8, 2024

@ed255 @ChihChengLiang some notes about this:

It seems that we need to implement variable-length arithmetics, because the bigint lengths are not fixed. So, if building EXP was complex, let's do mainly looping with MULADD and MULMOD with variable length of base exponent and modulus is not trivial at all.

Let's say that this could be done in common Halo2 frontend, in the sake of building new halo2 reusable chips, that could be ok, but I see that nobody is going to use this chips because serious crypto is done with fixed length not variable-length-everything, so I do not expect to be reusable at all.

Also this is not a very used precompile, and exists for verifying RSA ( that typically is 2048/4096) signatures, that is more in the "corporate" world that in the crypto space.

So, a loooot of work for a barely-used and probably non-reusable circuit. Anyway, there's the precompile and needs to be implemented.

I checked some implementations:

Scroll: only supports up to 256 bits, and does not plan to support the full precompile. Unsure if we can reuse it for variable-length.
Polygon: also only supports up to 256 bits.
zkSync: just is not implemented. But looking for more implementations I found that zkSync is following a strategy to implement precompiles using the EVM, so exists an implementation written in YUL there

So this gives some different strategies that we can follow (at least):

  1. Implement, as usual, as a halo2 circuit with the usual rust frontend
  2. Use EVM code installed in the precompile address (note that we can use this also for blake2f and RIPEMD-160
  3. Implement as a HALO2 circuit, but try to find how to write a frontend to handle it with less drama (something like powdr?)

@ed255 ed255 moved this from 📋 Sprint Focus to Milestone Tasks in zkEVM Community Edition Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Milestone Tasks
Development

No branches or pull requests

4 participants