Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Support EIP-1559 #490

Open
KimiWu123 opened this issue Sep 19, 2023 · 3 comments
Open

Support EIP-1559 #490

KimiWu123 opened this issue Sep 19, 2023 · 3 comments
Labels
T-feature Type: new features

Comments

@KimiWu123
Copy link
Contributor

see #69 for more details

@KimiWu123 KimiWu123 added the T-feature Type: new features label Sep 19, 2023
@KimiWu123 KimiWu123 added this to the Feature Completeness milestone Sep 19, 2023
@KimiWu123 KimiWu123 moved this to Milestone Tasks in zkEVM Community Edition Sep 19, 2023
@KimiWu123 KimiWu123 moved this from Milestone Tasks to 📋 Sprint Focus in zkEVM Community Edition Sep 20, 2023
@KimiWu123 KimiWu123 moved this from 📋 Sprint Focus to Milestone Tasks in zkEVM Community Edition Sep 21, 2023
@ed255
Copy link
Member

ed255 commented Oct 5, 2023

I think Taiko/Scroll may already have this implemented?

@lispc
Copy link
Collaborator

lispc commented Oct 5, 2023

We have this partially implemented. The evm circuit can support 1559 related mechanism (like fee burn) and rlp circuit/tx circuit can accept 1559 txs(but may not fully sound now). But we have not implemented the basefee mechanism itself such as how it is adjusted.

@Brechtpd
Copy link
Collaborator

Brechtpd commented Oct 5, 2023

We also only have partial support at this point. We do the basefee adjusting code in a smart contract so we don't have to implement it in a dedicated circuit, but this approach doesn't seem easy for standard Ethereum blocks. We also don't use the standard EIP-1559 formula because that one only works with fixed block times and blocks that efficiently support dynamic sizes (but with the chunked prover this last problem should be solved).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-feature Type: new features
Projects
Status: Milestone Tasks
Development

No branches or pull requests

4 participants