You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the output of the latest develop branch with cleye breaks its types. Screenshot below:
I used git bisect to find what change broke it (In case you want to try, I didn't do any fancy npm linking, I just copied the dist folder into my local cleye clone. So I just ran this command for each commit git bisect suggested: pnpm i; git checkout pnpm-lock.yaml; pnpm build; rm -rf ../cleye/node_modules/type-flag/dist; rsync -r dist ../cleye/node_modules/type-flag; (cd ../cleye; pnpm build 2> /dev/null). That command succeeded on master, and failed on develop because of the above typescript error.
I guess one of the any -> unknown changes broke it the typearg extends condition somehow. I'll try to find to time to dig into which exactly, but commenting in the meantime in case anything springs to mind.
Just run pnpm install && pnpm build in the above - I pushed a change to package.json in the cleye repo to install type-flag from github, then cd into node_modules and build type-flag directly before building cleye. mmkal/cleye@cd34e3a
Version
develop
Node.js version
v18.20.3, but not really relevant
Package manager
pnpm, but not really relevant
Operating system
macOS, but not really relevant
Bugs are expected to be fixed by those affected by it
I'm interested in working on this issue
Compensating engineering work financially will speed up resolution
I'm willing to offer financial support
The text was updated successfully, but these errors were encountered:
Problem
Using the output of the latest
develop
branch with cleye breaks its types. Screenshot below:I used
git bisect
to find what change broke it (In case you want to try, I didn't do any fancy npm linking, I just copied the dist folder into my localcleye
clone. So I just ran this command for each commit git bisect suggested:pnpm i; git checkout pnpm-lock.yaml; pnpm build; rm -rf ../cleye/node_modules/type-flag/dist; rsync -r dist ../cleye/node_modules/type-flag; (cd ../cleye; pnpm build 2> /dev/null)
. That command succeeded onmaster
, and failed ondevelop
because of the above typescript error.git bisect
result:5fcb9cc is the first bad commit
commit 5fcb9cc
Author: Hiroki Osame [email protected]
Date: Tue Apr 16 23:48:44 2024 +0900
6 files changed, 1587 insertions(+), 790 deletions(-)
I guess one of the
any
->unknown
changes broke it the typearg extends condition somehow. I'll try to find to time to dig into which exactly, but commenting in the meantime in case anything springs to mind.Originally posted by @mmkal in #27 (comment)
Expected behavior
Output of this library to work with
cleye
- but maybe this issue would be better solved in thecleye
repo, not sure?Minimal reproduction URL
https://stackblitz.com/~/github.com/mmkal/cleye
Just run
pnpm install && pnpm build
in the above - I pushed a change to package.json in the cleye repo to installtype-flag
from github, then cd into node_modules and build type-flag directly before building cleye. mmkal/cleye@cd34e3aVersion
develop
Node.js version
v18.20.3, but not really relevant
Package manager
pnpm, but not really relevant
Operating system
macOS, but not really relevant
Bugs are expected to be fixed by those affected by it
Compensating engineering work financially will speed up resolution
The text was updated successfully, but these errors were encountered: