Skip to content

Commit 3c811f3

Browse files
committed
editor contrast issue (#3579)
1 parent 0ccfd0e commit 3c811f3

File tree

2 files changed

+19
-18
lines changed

2 files changed

+19
-18
lines changed

.env.example

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ GITHUB_ID=<your-github-client-id>
1414
GITHUB_SECRET=<your-github-client-secret>
1515
GOOGLE_ID=<your-google-client-id> (use google+ api)
1616
GOOGLE_SECRET=<your-google-client-secret> (use google+ api)
17-
MAILGUN_DOMAIN=<your-mailgun-domain>
18-
MAILGUN_KEY=<your-mailgun-api-key>
17+
MAILGUN_DOMAIN=<your-maiaasxslgun-domain>
18+
MAILGUN_KEY=<your-mailgxasxasxun-key>
1919
ML5_LIBRARY_USERNAME=ml5
2020
ML5_LIBRARY_EMAIL=[email protected]
2121
ML5_LIBRARY_PASS=helloml5
22-
MONGO_URL=mongodb://localhost:27017/p5js-web-editor
22+
MONGO_URL=mongodb+srv://jeelrupareliya255:[email protected]/
2323
PORT=8000
2424
PREVIEW_PORT=8002
2525
EDITOR_URL=http://localhost:8000

client/styles/abstracts/_variables.scss

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
$base-font-size: 12;
22

3-
//colors
3+
44
$p5js-pink: #ed225d;
5+
$p5js-pink-text: #C11245;
56
$p5js-pink-opacity: #ed225d80;
67
$p5js-active-pink: #f10046;
78
$white: #fff;
@@ -12,17 +13,17 @@ $p5-contrast-pink: #FFA9D9;
1213

1314
$outline-color: #0F9DD7;
1415

15-
// Grayscale values
16-
$lightest: #FFF; // primary
16+
17+
$lightest: #FFF;
1718
$lighter: #FBFBFB;
1819

19-
$light: #F0F0F0; // primary
20+
$light: #F0F0F0;
2021
$medium-light: #D9D9D9;
2122
$middle-light: #A6A6A6;
2223

23-
// $middle-gray: #7D7D7D; // primary
24-
$middle-gray: #747474; // primary
25-
$middle-dark: #666;
24+
25+
$middle-gray: #747474;
26+
$middle-dark: #666;
2627
$medium-dark: #4D4D4D;
2728

2829
$dark: #333; // primary
@@ -42,7 +43,7 @@ $themes: (
4243
button-background-color: $light,
4344
button-secondary-background-color: $medium-light,
4445
button-color: $black,
45-
button-border-color: $middle-light,
46+
button-border-color: $middle-dark,
4647
toolbar-button-color: $dark,
4748
toolbar-button-background-color: $medium-light,
4849
button-background-hover-color: $p5js-pink,
@@ -52,7 +53,7 @@ $themes: (
5253
button-active-color: $lightest,
5354
modal-background-color: $light,
5455
preferences-button-background-color: $medium-light,
55-
modal-border-color: $middle-light,
56+
modal-border-color: $middle-dark,
5657
icon-color: $middle-gray,
5758
icon-hover-color: $darker,
5859
icon-toast-hover-color: $lightest,
@@ -64,7 +65,7 @@ $themes: (
6465
console-active-arrow-color: #0071AD,
6566
console-header-background-color: $medium-light,
6667
console-header-color: $darker,
67-
ide-border-color: $medium-light,
68+
ide-border-color: $middle-dark,
6869
editor-gutter-color: $lighter,
6970
file-hover-color: $light,
7071
file-selected-color: $medium-light,
@@ -73,14 +74,14 @@ $themes: (
7374
input-secondary-background-color: $lightest,
7475
input-selection-text-color: $dark,
7576
input-selection-background-color: $medium-light,
76-
input-border-color: $middle-light,
77+
input-border-color: $middle-dark,
7778
search-background-color: $lightest,
7879
search-clear-background-color: $light,
7980
search-hover-text-color: $lightest,
8081
search-hover-background-color: $medium-dark,
8182
keyboard-shortcut-color: $middle-gray,
8283
nav-hover-color: $p5js-pink,
83-
nav-border-color: $middle-light,
84+
nav-border-color: $middle-dark,
8485
error-color: $p5js-pink,
8586
table-row-stripe-color: $medium-light,
8687
table-row-stripe-color-alternate: $medium-light,
@@ -95,8 +96,8 @@ $themes: (
9596
table-button-hover-color: $lightest,
9697
table-button-background-hover-color: $p5js-pink,
9798

98-
progress-bar-background-color: $middle-gray,
99-
progress-bar-active-color: $p5js-active-pink,
99+
progress-bar-background-color: $light,
100+
progress-bar-active-color: $p5js-pink,
100101

101102
form-title-color: rgba(51, 51, 51, 0.87),
102103
form-secondary-title-color: $medium-dark,
@@ -174,7 +175,7 @@ $themes: (
174175
input-secondary-background-color: $medium-dark,
175176
input-selection-text-color: $darkest,
176177
input-selection-background-color: $lightest,
177-
input-border-color: $middle-dark,
178+
input-border-color: $light, // Improved from $middle-dark for better contrast in dark theme
178179
search-background-color: $darker,
179180
search-clear-background-color: $medium-dark,
180181
search-hover-text-color: $lightest,

0 commit comments

Comments
 (0)