Skip to content

Commit 4dea2f1

Browse files
committed
Fix some Elvis reports
1 parent 1d5b9bb commit 4dea2f1

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

elvis.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
{elvis_style, function_naming_convention, disable},
1717
{elvis_style, god_modules, #{limit => 300}},
1818
{elvis_style, invalid_dynamic_call, disable},
19+
{elvis_style, macro_names, disable},
1920
{elvis_style, max_function_arity, disable}, % #{max_arity => 15}},
2021
{elvis_style, nesting_level, disable},
2122
{elvis_style, no_author, disable},

src/mod_http_api.erl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ process([Call | _], #request{method = 'POST', data = Data, ip = IPPort} = Req) -
145145
%% TODO We need to refactor to remove redundant error return formatting
146146
throw:{error, unknown_command} ->
147147
json_format({404, 44, <<"Command not found.">>});
148-
_:{error,{_,invalid_json}} = _Err ->
149-
?DEBUG("Bad Request: ~p", [_Err]),
148+
_:{error,{_,invalid_json}} = Err ->
149+
?DEBUG("Bad Request: ~p", [Err]),
150150
badrequest_response(<<"Invalid JSON input">>);
151-
?EX_RULE(_Class, _Error, Stack) ->
151+
?EX_RULE(_Class, Error, Stack) ->
152152
StackTrace = ?EX_STACK(Stack),
153-
?DEBUG("Bad Request: ~p ~p", [_Error, StackTrace]),
153+
?DEBUG("Bad Request: ~p ~p", [Error, StackTrace]),
154154
badrequest_response()
155155
end;
156156
process([Call | _], #request{method = 'GET', q = Data, ip = {IP, _}} = Req) ->
@@ -166,9 +166,9 @@ process([Call | _], #request{method = 'GET', q = Data, ip = {IP, _}} = Req) ->
166166
%% TODO We need to refactor to remove redundant error return formatting
167167
throw:{error, unknown_command} ->
168168
json_format({404, 44, <<"Command not found.">>});
169-
?EX_RULE(_, _Error, Stack) ->
169+
?EX_RULE(_, Error, Stack) ->
170170
StackTrace = ?EX_STACK(Stack),
171-
?DEBUG("Bad Request: ~p ~p", [_Error, StackTrace]),
171+
?DEBUG("Bad Request: ~p ~p", [Error, StackTrace]),
172172
badrequest_response()
173173
end;
174174
process([_Call], #request{method = 'OPTIONS', data = <<>>}) ->

0 commit comments

Comments
 (0)