Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify people search to illustrate how to use query params #157

Open
professor opened this issue Jan 24, 2013 · 6 comments
Open

Modify people search to illustrate how to use query params #157

professor opened this issue Jan 24, 2013 · 6 comments

Comments

@professor
Copy link
Owner

How do we want to document this? I don't want to clutter your page. Perhaps we put it in ruby doc and link to a web page? If we take care of the other issue, this one might go away.

@kaushikgopal
Copy link

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

@professor
Copy link
Owner Author

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal [email protected] wrote:

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?


Reply to this email directly or view it on GitHub.

@kaushikgopal
Copy link

I was thinking of that, but wouldn't that force a page refresh when we
modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal [email protected]
wrote:

We could add a single line showing the link being built (within the
advanced search parameter box itself), as they keep adding filters?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.

@professor
Copy link
Owner Author

I don't think so - see google mail

Sent from my iPhone

On Jan 23, 2013, at 8:04 PM, kaushikgopal [email protected] wrote:

I was thinking of that, but wouldn't that force a page refresh when we
modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal [email protected]
wrote:

We could add a single line showing the link being built (within the
advanced search parameter box itself), as they keep adding filters?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.


Reply to this email directly or view it on GitHub.

@professor
Copy link
Owner Author

Lets do bobs idea first, we might not need to document the query parsms as one can always look at the code.

Sent from my iPhone

On Jan 23, 2013, at 8:04 PM, kaushikgopal [email protected] wrote:

I was thinking of that, but wouldn't that force a page refresh when we
modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal [email protected]
wrote:

We could add a single line showing the link being built (within the
advanced search parameter box itself), as they keep adding filters?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.


Reply to this email directly or view it on GitHub.

@kaushikgopal
Copy link

just noticed a way of editing the existing url without refreshing the page (using HTML5 history-api) : http://warpspire.com/experiments/history-api/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants