Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

Rename settings.json to settings.json.example, ignore settings.json #54

Open
rgoliveira opened this issue Feb 23, 2017 · 1 comment
Open

Comments

@rgoliveira
Copy link
Member

Since said file (settings.json) could be adjusted by someone running the bot, it doesn't really make sense to have it on version control. We should, however, keep an example of it (always updated, if possible), aka settings.json.example.

Similar thing happened to tokens.json, although this one was created to move tokens out of settings.json. When we deal with this, maybe we could just move the tokens back into the main settings?

@rgoliveira
Copy link
Member Author

One problem to consider: current tests (read Travis CI) uses settings.json in its instance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant