RUSTSEC-2021-0131: Integer overflow in the bundled Brotli C library

[github-actions]

Integer overflow in the bundled Brotli C library

Details
Package	brotli-sys
Version	0.3.2
URL	bitemyapp/brotli2-rs#45
Date	2021-12-20

A buffer overflow exists in the Brotli library versions prior to 1.0.8 where an attacker controlling the input length of a "one-shot" decompression request to a script can trigger a crash, which happens when copying over chunks of data larger than 2 GiB.

An updated version of brotli-sys has not been released. If one cannot update the C library, its authors recommend to use the "streaming" API as opposed to the "one-shot" API, and impose chunk size limits.

In Rust the issue can be mitigated by migrating to the brotli crate, which provides a Rust implementation of Brotli compression and decompression that is not affected by this issue.

See advisory page for additional details.

[kate-goldenring]

This only affects our Configuration Admission Controller Webhook, which is rarely if ever used. The webhook brings this in via actix-web. actix-web is working on replacing their use of brotli-sys with brotli. However, if we wanted a more immediate solution, we could switch which web framework the webhook is using, to warp for example.

[github-actions]

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

[github-actions]

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

[johnsonshih]

dependency on actix-web had been updated, we no longer have dependency on brotli-sys.