Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test documentation examples as part of E2E tests #591

Open
diconico07 opened this issue Apr 25, 2023 · 7 comments
Open

Test documentation examples as part of E2E tests #591

diconico07 opened this issue Apr 25, 2023 · 7 comments
Labels

Comments

@diconico07
Copy link
Contributor

Current E2E test suite test the controller and agent by using the debug-echo discovery handler, as such the other discovery handlers don't get tested as part of E2E tests.

It would be a really nice addition to add tests for all the examples we have in the documentation, this would ensure they are really functional and is in my opinion a good starting point to do E2E tests on all discovery handlers as those examples are set to be easily reproduced.

@kate-goldenring
Copy link
Contributor

+1

@LavenderQAQ
Copy link

@kate-goldenring Hello, may I ask if this issue needs to be modified run-end-to-end.py to test onvif, opcua and udev? I want to participate in this issue, but I don't quite understand where the documentation is.

@diconico07
Copy link
Contributor Author

Hi @LavenderQAQ,
the idea is to modify run-end-to-end.py to be able to test the different use cases highlighted in the demos section of the doc:

The overall idea is to ensure these documented demos are regularly tested.

@LavenderQAQ
Copy link

LavenderQAQ commented May 4, 2023

@diconico07 Ok, thank you for your detailed explanation. @kate-goldenring I want to finish this issue 😻.

@kate-goldenring
Copy link
Contributor

@LavenderQAQ help on this would be greatly appreciated! @diconico07 is spot on. For onvif, @cliffordt3 did some work several months back to containerize the onvif demo. Some of that work is captured in this PR kate-goldenring/onvif-camera-mocking#4.

Doing udev, opc ua, and onvif all at once may be a lot, so it may be best to tackle one, PR it in and then go for the next.

@LavenderQAQ
Copy link

@kate-goldenring Sorry, I don't have time to follow up this issue at present because of some other projects😵‍💫. Very sorry for that.

@kate-goldenring
Copy link
Contributor

@LavenderQAQ no worries. Feel free to ping if time arises in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

3 participants