Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery response metrics to Agent #665

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Oct 9, 2023

What this PR does / why we need it:
This PR adds two Prometheus metrics to Agent.

  • akri_discovery_response_time: histogram of the discovery response latency from the time a Configuration is created/updated to the request sent to discovery handler
  • akri_discovery_response_result: counter of the success/fail results when Agent invokes discover() to discovery handler

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Copy link
Contributor

@diconico07 diconico07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, don't forget to do the corresponding doc PR adding the new metrics there as well.

@johnsonshih
Copy link
Contributor Author

Looks good to me, don't forget to do the corresponding doc PR adding the new metrics there as well.

sure, will push a doc update pr for the new metrics

@johnsonshih
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Oct 10, 2023
github-actions bot and others added 3 commits October 10, 2023 14:18
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih johnsonshih merged commit cc29959 into project-akri:main Oct 10, 2023
28 of 40 checks passed
@johnsonshih johnsonshih deleted the user/jshih/agent-telemetry branch October 10, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants