From 05f4297ab9e3ea804055f70969535712522c6fac Mon Sep 17 00:00:00 2001 From: cecille Date: Tue, 17 Sep 2024 16:42:30 -0400 Subject: [PATCH] Fix command check (merge conflict?) --- src/python_testing/TC_DeviceConformance.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/python_testing/TC_DeviceConformance.py b/src/python_testing/TC_DeviceConformance.py index a6d6f19bfb53e7..86a981c86cde15 100644 --- a/src/python_testing/TC_DeviceConformance.py +++ b/src/python_testing/TC_DeviceConformance.py @@ -166,7 +166,6 @@ def record_warning(location, problem): if attribute_id not in self.xml_clusters[cluster_id].attributes.keys(): # TODO: Consolidate the range checks with IDM-10.1 once that lands if attribute_id <= 0x4FFF: - # manufacturer attribute record_error(location=location, problem='Standard attribute found on device, but not in spec') continue xml_attribute = self.xml_clusters[cluster_id].attributes[attribute_id] @@ -193,9 +192,7 @@ def check_spec_conformance_for_commands(command_type: CommandType): if command_id not in xml_commands_dict: # TODO: Consolidate range checks with IDM-10.1 once that lands if command_id <= 0xFF: - # manufacturer command - continue - record_error(location=location, problem='Standard command found on device, but not in spec') + record_error(location=location, problem='Standard command found on device, but not in spec') continue xml_command = xml_commands_dict[command_id] conformance_decision_with_choice = xml_command.conformance(feature_map, attribute_list, all_command_list)