[Android] Fix memory leakage in AndroidLogDownloadFromNode Class #36742
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
joonhaengHeo
force-pushed
the
fix_memory_issue_in_diag_class
branch
from
50b05db to
787eb20
Compare
joonhaengHeo
force-pushed
the
fix_memory_issue_in_diag_class
branch
from
787eb20 to
8830a42
Compare
|
PR #36742: Size comparison from cbf92b7 to 8830a42 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Dec 6, 2024
yunhanw-google
requested changes
Dec 6, 2024
| static_cast<jlong>(mRemoteNodeId), static_cast<jlong>(err.AsInteger())); | ||
| exit: | ||
| // Finish this function, this object will be deleted. | ||
| delete this; |
There was a problem hiding this comment.
this is not correct, this function is inside callback, you cannot delete this, you should pass context object(AndroidLogDownloadFromNode) from the callback inside FinishLogDownloadFromNode, then delete in the end.
andy31415
requested changes
Dec 13, 2024
There was a problem hiding this comment.
@joonhaengHeo this also needs a Testing section in the summary to explain how this was tested.
Since this did not update any unit tests, the testing is manual so we need to meet a higher bar (make it less convenient for most PRs to just be manually tested because it is easier) so we need a more detailed description on how the manual tests were done as well as a justification why automated testing of the newly added code is impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36734
Fixed an issue where memory was not deleted after finishing AndroidLogDownloadFromNode.