Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct calls for emberAfAttributeChanged from libCHIP (reporting.cpp) and make these part of CodegenDataModel #36661

Open
andy31415 opened this issue Nov 27, 2024 · 1 comment · May be fixed by #36756
Assignees

Comments

@andy31415
Copy link
Contributor

https://github.com/project-chip/connectedhomeip/blob/master/src/app/reporting/reporting.cpp contains just a wrapper for attribute change callbacks.

However this is directly ember coupled and uses a global attribute change listener. For backwards compatibility we should maintain MatterReportingAttributeChangeCallback existing, however because it is ember-tied it should be part of the Codegen data model provider rather than direct libCHIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment