[1.4] Water heater / Missing Thermostat cluster

[lboue]

Reproduction steps

Thermostat cluster is mandatory for WaterHeater device type but not implemented in device example :

WaterHeater.xml#L74

    <cluster id="0x0201" name="Thermostat" side="server">

WaterHeater device type example

Thermostat cluster is not implemented in the ZAP file

https://github.com/project-chip/connectedhomeip/blob/master/examples/energy-management-app/energy-management-common/water-heater/src/WhmDelegateImpl.cpp#L303-L316

int16_t WaterHeaterManagementDelegate::GetActiveTargetWaterTemperature() const
{
    // Determine the target temperature. If a boost command is in progress and has a mBoostTemporarySetpoint value use that as the
    // target temperature.
    // Note, in practise the actual heating is likely to be controlled by the thermostat's occupiedHeatingSetpoint most of the
    // time, and the TemporarySetpoint (if not null) would be overiding the thermostat's occupiedHeatingSetpoint.
    // However, this code doesn't rely upon the thermostat cluster.
    // TODO: Implement Thermostat Cluster temperature handling. It's mandatory to be spec conformant.
    int16_t targetTemperature = (mBoostState == BoostStateEnum::kActive && mBoostTemporarySetpoint.HasValue())
        ? mBoostTemporarySetpoint.Value()
        : mTargetWaterTemperature;

    return targetTemperature;
}

Bug prevalence

always

GitHub hash of the SDK that was being used

2c11741

Platform

core

Platform Version(s)

1.4

Type

Spec Compliance Issue

Anything else?

Water heater