Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and format scripts don't work on Windows #425

Open
lauckhart opened this issue Oct 21, 2023 · 0 comments
Open

Lint and format scripts don't work on Windows #425

lauckhart opened this issue Oct 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lauckhart
Copy link
Collaborator

Two points from @vilic:

  1. Windows shell doesn't support the single quoted strings we use for formatting and lint commands; and
  2. It'd arguably be more elegant to blacklist using ignore dotfiles than the current whitelist approach

Implementing point 2 would resolve this issue.
@lauckhart lauckhart mentioned this issue Oct 21, 2023
Merged
@Apollon77 Apollon77 added the bug Something isn't working label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
[SDK] Matter.js
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lauckhart @Apollon77