Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I change the Display Name? #94

Open
svn-matterize opened this issue Apr 14, 2023 · 9 comments
Open

How can I change the Display Name? #94

svn-matterize opened this issue Apr 14, 2023 · 9 comments
Labels
Likely-AppleHome-issue This issue is likely caused by Apple Home/iOS Likely-GoogleHome-issue This issue is likely caused by Apple Google Home question Further information is requested

Comments

@svn-matterize
Copy link

Hello,

I wanted to change the discovery name from "Matter Accessory" to the custom name, so I changed the nodeLable in Device.ts file:

However when I try to add it in the Apple Homekit it shows as "Matter Accessory" instead of the given name.

@Apollon77
Copy link
Collaborator

Thats a good question ... From my experience each platform ignores the names we send ... in iOS you always get "Matter Accessory", in Alexa it is always "First Light" (kind of) ... and such ... We could try to play around with a Fixed label CLuster and such ... but I did not had time till now for such deep looks and tries

@Apollon77 Apollon77 added the question Further information is requested label Apr 14, 2023
@svn-matterize
Copy link
Author

svn-matterize commented Apr 14, 2023

Fixed label cluster, are you refering to Basic Information Cluster?

@svn-matterize
Copy link
Author

I've also noted that setting the device type also have no effect in Homekit. I.E, it always shows the Home Icon instead of the specified device type icon in the discovery.

Have you played around with this earlier?

@Apollon77
Copy link
Collaborator

Apollon77 commented Apr 14, 2023

Fixed label cluster, are you refering to Basic Information Cluster?

No, there are "LabelClusters" ... but I also have no idea what is used maybe from that.

Icon:

Same, no idea why they do what they do (meaning the controllers) :-(

It is all the begin of a journey and with near to no real devices out there it is always hard - also for them

@svn-matterize
Copy link
Author

With the real devices, the behaviour is same as well. I've working with esp-matter.

Since the eco-system providers mention, they implemented the Matter 1.0 spec, I believe this labels are included.

@lboue
Copy link
Contributor

lboue commented Apr 14, 2023

Device names display correctly with a certified Matter over WIFI device or a Hue Bridge.
Did you genarate Factory Data ?

Did you read that tutorial?

3.2.2.2 Generating Factory Partition Binary Files

Generate factory partition binary files

./mfg_tool.py -n <count> -cn Espressif --paa -c /path/to/PAA_certificate -k /path/to/PAA_key \
              -cd /path/to/CD_file -v 0x131B --vendor_name Espressif -p 0x1234 \
              --product-name Test-light --hw-ver 1 --hw-ver-str v1.0

@Apollon77
Copy link
Collaborator

because we do not use ESP32 stuff we generate all these details ... yes. So the question is if they are correctly used for other "uncertified devices"?

@lboue
Copy link
Contributor

lboue commented Apr 15, 2023

I think you should ask the question here in the connectedhomeip repo:
https://github.com/project-chip/connectedhomeip/issues

@lboue
Copy link
Contributor

lboue commented Apr 16, 2023

Fixed label cluster, are you refering to Basic Information Cluster?

No, there are "LabelClusters" ... but I also have no idea what is used maybe from that.

Icon:

Same, no idea why they do what they do (meaning the controllers) :-(

It is all the begin of a journey and with near to no real devices out there it is always hard - also for them

You should have a look a this PR about User Label Cluster: [GH_PR] Added User Label Cluster to generic_switch example.

This example creates a Generic Switch device using the ESP
Matter data model.
This example aims to demonstrate the use of Fixed Label Cluster and User Label Cluster which provide a feature for the device to tag an endpoint with zero or more read-only labels using nvs api and zero or more labels respectively.

Note:
    In order to retrieve the label-list from the fixed-label cluster the two options:
    ``CONFIG_ENABLE_ESP32_FACTORY_DATA_PROVIDER`` and ``CONFIG_ENABLE_ESP32_DEVICE_INFO_PROVIDER`` have been set through sdkcofig.defaults.

And this issue:
generic switch example should also include user_label (CON-391)

This is a test for that in the CHIP Test Suites:
Basic Information Cluster Tests

@Apollon77 Apollon77 added Likely-AppleHome-issue This issue is likely caused by Apple Home/iOS Likely-GoogleHome-issue This issue is likely caused by Apple Google Home labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Likely-AppleHome-issue This issue is likely caused by Apple Home/iOS Likely-GoogleHome-issue This issue is likely caused by Apple Google Home question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants