feat: mTLS-over-TCP buildkit #284
Conversation
RealHarshThakur
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 31.80% 31.93% +0.12%
==========================================
Files 18 18
Lines 1597 1622 +25
==========================================
+ Hits 508 518 +10
- Misses 1061 1073 +12
- Partials 28 31 +3
☔ View full report in Codecov by Sentry. |
RealHarshThakur
force-pushed
the
tcpbuildkit
branch
from
b94ff16 to
0c9f936
Compare
|
Guessing the test failures are unrelated to this change? As I see them here as well: #287 Please do let me know if you folks think there is a test you'd like to see. I've followed the same pattern that buildctl CLI has to set up the client. |
Yes it's happening across all PRs at the moment, working on addressing it |
|
@RealHarshThakur - test issue should be resolved now :) |
Signed-off-by: Harsh Thakur <[email protected]>
Signed-off-by: Harsh Thakur <[email protected]>
RealHarshThakur
force-pushed
the
tcpbuildkit
branch
from
2f1bd81 to
697cb21
Compare
|
This is looking good to me - @sozercan do you have a chance to review? |
pkg/patch/cmd.go
Outdated
| reportFile string | ||
| patchedTag string | ||
| workingFolder string | ||
| buildkitAddr string |
There was a problem hiding this comment.
Instead of explicitly defining these addr/cert args here, can use buildkit.Opts and set the flags to use &bkopts.<Field>
Signed-off-by: Harsh Thakur <[email protected]>
Adds flags to enable Copa to connect to a remote Buildkit listening on TCP address secured via mTLS.
This is very similar to creating a remote buildx driver as described here.
Closes #285