Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Synthesis does not fail when players are hit during combat #1452

Open
2 tasks done
Era-Lusiphur opened this issue Oct 29, 2020 · 2 comments
Open
2 tasks done

Synthesis does not fail when players are hit during combat #1452

Era-Lusiphur opened this issue Oct 29, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Era-Lusiphur
Copy link
Contributor

I have:

  • searched existing issues (http://project-topaz.com/issues/) to see if the issue has already been opened
  • checked the commit log to see if the issue has been resolved since my server was last updated

Additional Information (Steps to reproduce/Expected behavior) :
Synthesis should fail when players receive damage during combat. Currently it does not affect the outcome of the synth. Evaded attacks should not have an effect on synthesis outcome.

Opened issue per Zach.

@zach2good
Copy link
Contributor

I've done about 90s of research, I don't think we have a mechanism for marking items as "un-losable" in a failed synth. If we call doSynthFail (like we do when we're detecting abuse) things like Lu Shangs Rod can be lost - which is not correct in this case.

@zach2good
Copy link
Contributor

I don't remember who said it, but we had a vague confirmation that you lose all items if you're hit (just like if you force a zone during synth).

I'm happy to shift the "responsibility" of this onto server operators. If a player loses their expensive mats or their "unlosable" items in a synth they were attempting in the middle of a fight: they can explain to their local GM why they deserve their items back 🤡

@zach2good zach2good added the good first issue Good for newcomers label Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants