Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Allow specifying user and group scopes with OIDC authentication #2523

Open
AndersBennedsgaard opened this issue Jul 3, 2024 · 2 comments
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers

Comments

@AndersBennedsgaard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It should be possible to specify which claim to use for the user ID. Some users might want to use email, others might want to use sub.
Additionally, it should be possible to select a claim which is used for groups. This is already possible with LDAP:

UserGroupAttribute string

Describe the solution you'd like

Add userclaim and groupsclaim to OIDC provider config

Describe alternatives you've considered

No response

Additional context

No response

@AndersBennedsgaard AndersBennedsgaard added the feature New feature or request label Jul 3, 2024
@rchincha
Copy link
Contributor

rchincha commented Jul 3, 2024

@AndersBennedsgaard thanks for doing a thorough evaluation and identifying improvements for zot.
We would also respectfully urge you to consider posting PRs.

@AndersBennedsgaard
Copy link
Contributor Author

I have opened PRs in OSS projects before which have been closed with a "we do not agree with this" explanation. So I don't create PRs before I get an approval from the developers that it is something they want. If you do think it's a good improvement, and wouldn't mind contributions for it, you can say that you agree and add the good first issue Good for newcomers label

@rchincha rchincha added the rm-external Roadmap item submitted by non-maintainers label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers
Projects
None yet
Development

No branches or pull requests

2 participants