-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contour should expose more metrics about gRPC serving #1678
Comments
Thanks @youngnick! The first low-hanging fruit I see is to integrate the grpc-ecosystem/go-grpc-prometheus middleware into Contour. There is very little code to write to instrument the server: One important thing that is missing, however, is a Gauge to represent the number of connected clients (ie. number of Envoys). There is an open issue for exactly that: grpc-ecosystem/go-grpc-prometheus#78, but it could be done in Contour instead (or in addition to). Doing it in Contour gives extra flexibility in terms of labels. |
…tour#1678) Signed-off-by: Benoit Gagnon <[email protected]>
Thanks again for the PR, @bgagnon! I'm checking that one out, and once we've landed it, I'll have a look at adding the number of connected clients. |
Signed-off-by: Benoit Gagnon <[email protected]>
With the merging of #1692, we have basic stats about the connected clients. I don't think we're going to be able to land the number of connected clients in rc2, sadly, and we don't want to add any new functionality in the final 1.0.0. So, I'm moving this to the backlog for now. Please note that 'backlog' currently means 'after 1.0', not 'will never get done'. I think this is a really important and not that large feature, so I will make sure it doesn't disappear. |
As part of troubleshooting #1523, @FournierAlexandre and @bgagnon have been working on observing their Contour and Envoy installation, and have found that it would be really useful to have more metrics around Contour's gRPC serving.
This issue covers adding some more metrics to Contour to expose more information about what's happening with the connections to Envoy via gRPC.
Specifically, the main deliverables are:
The text was updated successfully, but these errors were encountered: