Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Envoy Pods take 30 seconds to terminate #136

Open
rosskukulinski opened this issue Jun 1, 2018 · 2 comments
Open

Envoy Pods take 30 seconds to terminate #136

rosskukulinski opened this issue Jun 1, 2018 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@rosskukulinski
Copy link
Contributor

Is this a BUG REPORT, PERFORMANCE REPORT or FEATURE REQUEST?:

Bug report

What happened:

Deleting an Envoy pod as part of the Gimbal daemonset takes a long time to exit (appears to take 30-seconds, the default grace period). Once the grace period ends, the process is SIGKILLED

What you expected to happen:

I expected the Envoy process to respect the SIGTERM and shutdown.

@rosskukulinski rosskukulinski added the kind/bug Categorizes issue or PR as related to a bug. label Jun 1, 2018
@stevesloka
Copy link
Member

I did some testing with this by customizing the terminationGracePeriodSeconds for the pod. I found if I set it to zero the pods immediately terminate, but it doesn't give envoy time to drain connections. Any other value seems to be ignored.

@rosskukulinski
Copy link
Contributor Author

I think we should avoid modifying terminationGracePeriodSeconds -- the default 30 seconds is probably fine. I think this issue would be fixed by #144.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants