This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Improve goroutine and error handling in the discoverers #225
Labels
discoverer
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/feature
Categorizes issue or PR as related to a new feature.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Use heptio/workgroup to improve handling of the multiple goroutines that are spawned in each of the discoverers. This will also help us to bubble up errors to main, and handle them appropriately.
An example of this is #224. We wanted to handle the case where re-auth failed 3 times, but there was no good way of bubbling up the error to main.go. We could make reconciler.Run return an error to bubble it up to main.go, and use heptio/workgroup to handle the goroutine part of it.
The text was updated successfully, but these errors were encountered: