Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-prometheus-stack] Missing spec prometheus.spec.serviceName #5272

Open
trouaux opened this issue Feb 5, 2025 · 1 comment · May be fixed by #5273
Open

[kube-prometheus-stack] Missing spec prometheus.spec.serviceName #5272

trouaux opened this issue Feb 5, 2025 · 1 comment · May be fixed by #5273
Labels
bug Something isn't working

Comments

@trouaux
Copy link

trouaux commented Feb 5, 2025

Describe the bug a clear and concise description of what the bug is.

On the Prometheus and PrometheusAgent CRs we are missing the serviceName spec which allows to define the service name used by Prometheus Statefulset

Setting it to {{ template "kube-prometheus-stack.fullname" . }}-prometheus will avoid the creation of the operated prometheus service

https://prometheus-operator.dev/docs/api-reference/api/#monitoring.coreos.com/v1.PrometheusSpec see serviceName

What's your helm version?

version.BuildInfo{Version:"v3.16.1", GitCommit:"5a5449dc42be07001fd5771d56429132984ab3ab", GitTreeState:"clean", GoVersion:"go1.22.7"}

What's your kubectl version?

Client Version: v1.30.8 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.30.8

Which chart?

kube-prometheus-stack

What's the chart version?

68.4.5

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

Anything else we need to know?

No response
@trouaux trouaux added the bug Something isn't working label Feb 5, 2025
@trouaux trouaux linked a pull request Feb 5, 2025 that will close this issue
Open
3 tasks
@zeritti
Copy link
Contributor

zeritti commented Feb 5, 2025

spec.serviceName in prometheus and prometheusAgent CRDs is quite a new feature just introduced in release 0.80.0. A KPS release with appVersion and CRDs of 0.80.0 has not been made as yet - this should be the first thing to do before providing support for custom serviceName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@trouaux @zeritti