From 7165770493f566869a809d6212e36d2518355e1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antoine=20Beaupr=C3=A9?= Date: Tue, 17 Dec 2024 14:48:35 -0500 Subject: [PATCH] notice code duplication between the CLI formatting code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Antoine Beaupré --- silence/silence.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/silence/silence.go b/silence/silence.go index 32728473b6..3083073269 100644 --- a/silence/silence.go +++ b/silence/silence.go @@ -1069,6 +1069,11 @@ func openReplace(filename string) (*replaceFile, error) { } // logging silence status changes. +// +// XXX: This rewrites some code present in cli/format/format.go, +// labelsMatcher() and cli/format/format_extended.go, +// FormatSilences(). Refactoring this seems a little out of scope for +// now. func (s *Silences) logginSilences(msg string, sil *pb.Silence) { var listMatchers []string var matcher_type_operator = map[string]string{