Skip to content

Commit 07e66ec

Browse files
authored
bom should not include guava - it was only for internal code reuse (#1269)
fixes #1268 Signed-off-by: Gregor Zeitlinger <[email protected]>
1 parent 31c7b6b commit 07e66ec

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

pom.xml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<properties>
1818
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1919
<automatic.module.name>--module-name-need-to-be-overriden--</automatic.module.name>
20+
<guava.version>33.4.0-jre</guava.version>
2021
<junit-jupiter.version>5.11.4</junit-jupiter.version>
2122
<otel.instrumentation.version>2.12.0-alpha</otel.instrumentation.version>
2223
<java.version>8</java.version>
@@ -82,16 +83,6 @@
8283
<module>prometheus-metrics-simpleclient-bridge</module>
8384
</modules>
8485

85-
<dependencyManagement>
86-
<dependencies>
87-
<dependency>
88-
<groupId>com.google.guava</groupId>
89-
<artifactId>guava</artifactId>
90-
<version>33.4.0-jre</version>
91-
</dependency>
92-
</dependencies>
93-
</dependencyManagement>
94-
9586
<dependencies>
9687
<dependency>
9788
<groupId>com.google.code.findbugs</groupId>
@@ -128,6 +119,7 @@
128119
<dependency>
129120
<groupId>com.google.guava</groupId>
130121
<artifactId>guava</artifactId>
122+
<version>${guava.version}</version>
131123
<scope>test</scope>
132124
</dependency>
133125
<dependency>

prometheus-metrics-instrumentation-guava/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
<dependency>
3838
<groupId>com.google.guava</groupId>
3939
<artifactId>guava</artifactId>
40+
<version>${guava.version}</version>
4041
<scope>provided</scope>
4142
</dependency>
4243
<dependency>

0 commit comments

Comments
 (0)