Lint C++ code.

Author: ry

BUILD.gn

@@ -129,6 +129,6 @@ executable("deno_cctest") {
     "cctest.cc",
   ]
   deps = [
-    "v8/third_party/googletest:gtest",
+    "//testing/gtest:gtest",
   ]
 }

cctest.cc

@@ -1,9 +1,12 @@
-#include "deno.h"
-#include "v8/third_party/googletest/src/googletest/include/gtest/gtest.h"
+// Copyright 2018 Ryan Dahl <[email protected]>
+// All rights reserved. MIT License.
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "./deno.h"
 
 TEST(SnapshotTest, InitializesCorrectly) {
   EXPECT_TRUE(true);
-  // TODO add actual tests
+  // TODO(ry) add actual tests
 }
 
 int main(int argc, char** argv) {

deno.cc

@@ -28,9 +28,9 @@ IN THE SOFTWARE.
 #include "v8/include/libplatform/libplatform.h"
 #include "v8/include/v8.h"
 
-#include "deno.h"
+#include "./deno.h"
 
-#define CHECK(x) assert(x) // TODO use V8's CHECK.
+#define CHECK(x) assert(x)  // TODO(ry) use V8's CHECK.
 
 // Extracts a C string from a v8::V8 Utf8Value.
 const char* ToCString(const v8::String::Utf8Value& value) {
@@ -118,7 +118,7 @@ void Print(const v8::FunctionCallbackInfo<v8::Value>& args) {
 // Sets the recv callback.
 void Recv(const v8::FunctionCallbackInfo<v8::Value>& args) {
   v8::Isolate* isolate = args.GetIsolate();
-  Deno* d = (Deno*)isolate->GetData(0);
+  Deno* d = reinterpret_cast<Deno*>(isolate->GetData(0));
   assert(d->isolate == isolate);
 
   v8::HandleScope handle_scope(isolate);

deno.h

@@ -1,7 +1,7 @@
 // Copyright 2018 Ryan Dahl <[email protected]>
 // All rights reserved. MIT License.
-#ifndef DENO_H
-#define DENO_H
+#ifndef DENO_H_
+#define DENO_H_
 
 #include <string>
 #include "v8/include/v8.h"
@@ -52,4 +52,4 @@ const char* deno_last_exception(Deno* d);
 void deno_dispose(Deno* d);
 void deno_terminate_execution(Deno* d);
 
-#endif  // DENO_H
+#endif  // DENO_H_

main.cc

@@ -1,9 +1,11 @@
+// Copyright 2018 Ryan Dahl <[email protected]>
+// All rights reserved. MIT License.
 #include <assert.h>
 #include <stdio.h>
 
 #include "v8/include/v8.h"
 
-#include "deno.h"
+#include "./deno.h"
 #include "natives_deno.cc"
 #include "snapshot_deno.cc"
 

snapshot_creator.cc

@@ -1,3 +1,5 @@
+// Copyright 2018 Ryan Dahl <[email protected]>
+// All rights reserved. MIT License.
 #include <assert.h>
 #include <stdio.h>
 #include <string.h>
@@ -7,7 +9,7 @@
 
 #include "v8/include/v8.h"
 
-#include "deno.h"
+#include "./deno.h"
 
 class StartupDataCppWriter {
  public:
@@ -39,9 +41,10 @@ class StartupDataCppWriter {
 
   void WriteSuffix() {
     char buffer[500];
-    sprintf(buffer, "const v8::StartupData* StartupBlob_%s() {\n", name_);
+    snprintf(buffer, sizeof(buffer),
+             "const v8::StartupData* StartupBlob_%s() {\n", name_);
     file_ << buffer;
-    sprintf(buffer, "  return &%s_blob;\n", name_);
+    snprintf(buffer, sizeof(buffer), "  return &%s_blob;\n", name_);
     file_ << buffer;
     file_ << "}\n\n";
   }
@@ -51,25 +54,28 @@ class StartupDataCppWriter {
     for (int i = 0; i < sd_.raw_size; i++) {
       if ((i & 0x1F) == 0x1F) file_ << "\n";
       if (i > 0) file_ << ",";
-      sprintf(buffer, "%u", static_cast<unsigned char>(sd_.data[i]));
+      snprintf(buffer, sizeof(buffer), "%u",
+               static_cast<unsigned char>(sd_.data[i]));
       file_ << buffer;
     }
     file_ << "\n";
   }
 
   void WriteData() {
     char buffer[500];
-    sprintf(buffer, "static const char %s_blob_data[] = {\n", name_);
+    snprintf(buffer, sizeof(buffer), "static const char %s_blob_data[] = {\n",
+             name_);
     file_ << buffer;
     WriteBinaryContentsAsCArray();
     file_ << "};\n";
-    sprintf(buffer, "static const int %s_blob_size = %d;\n", name_,
-            sd_.raw_size);
+    snprintf(buffer, sizeof(buffer), "static const int %s_blob_size = %d;\n",
+             name_, sd_.raw_size);
     file_ << buffer;
-    sprintf(buffer, "static const v8::StartupData %s_blob =\n", name_);
+    snprintf(buffer, sizeof(buffer), "static const v8::StartupData %s_blob =\n",
+             name_);
     file_ << buffer;
-    sprintf(buffer, "{ (const char*) %s_blob_data, %s_blob_size };\n", name_,
-            name_);
+    snprintf(buffer, sizeof(buffer),
+             "{ (const char*) %s_blob_data, %s_blob_size };\n", name_, name_);
     file_ << buffer;
   }