Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple-cursors bar are invisible #62

Open
in-in opened this issue Jan 16, 2023 · 6 comments
Open

multiple-cursors bar are invisible #62

in-in opened this issue Jan 16, 2023 · 6 comments
Labels
cannot-reproduce-it I have tried, but cannot reproduce the bug on my end

Comments

@in-in
Copy link

in-in commented Jan 16, 2023

The bar seems to be the same color as the background, so it is invisible.
23016053638

@protesilaos
Copy link
Owner

Hello @in-in! Can you please tell me more about your setup? What version of the modus-themes are you using? What version of Emacs?

Does this problem occur in specific scenaria or is it always like this?

@in-in
Copy link
Author

in-in commented Jan 16, 2023

GNU Emacs 28.1
modus-themes 20230115.515
Yes, it is always invisible

@protesilaos
Copy link
Owner

I cannot reproduce this. In my case, I use the command mc/mark-next-like-this and all cursors are visible. This happens regardless of whether my original cursor is a block or a bar.

Is your problem limited to the modus-themes or does it happen with other themes as well?

@protesilaos
Copy link
Owner

Also note that your screenshot does not look like a Modus theme. Make sure no other theme is interfering by disabling it with M-x disable-theme.

@protesilaos protesilaos added the cannot-reproduce-it I have tried, but cannot reproduce the bug on my end label Jan 21, 2023
@yrns
Copy link

yrns commented Apr 29, 2023

I also had the same problem with the vertical bar cursor and multiple-cursors' "fake" cursors being invisible only with modus. There is some discussion related to this over in the multiple-cursors repo (magnars/multiple-cursors.el#367). There seems to be some subtleties with the cursor face being inverted and the timing of things being set. I found this configuration worked for me (note the colors are reversed):

(use-package modus-themes
  :ensure t
  :custom-face
  (mc/cursor-bar-face ((t (:height 1 :foreground "#ffffff" :background "#000000"))))
  :config
  (load-theme 'modus-operandi))

@protesilaos
Copy link
Owner

protesilaos commented May 2, 2023

Good to know @yrns!

What you are doings with the :custom-face should be the same as what we have in the themes:

    `(mc/cursor-bar-face ((,c :height 1 :foreground ,fg-main :background ,bg-main)))
    `(mc/cursor-face ((,c :inverse-video t)))

Maybe it suffices to remove all the multiple-cursors faces from the themes?

EDIT: Though you are suggesting that mc/cursor-bar-face is reversed regardless, which is unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cannot-reproduce-it I have tried, but cannot reproduce the bug on my end
Projects
None yet
Development

No branches or pull requests

3 participants