Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go: Add JSON tags to oneof values and members #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3v1n0
Copy link

@3v1n0 3v1n0 commented Nov 29, 2023

Oneof values should include json tags to use proper camelCase name and can be safely omitted when we're handling the interface.

Copy link

google-cla bot commented Nov 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@3v1n0 3v1n0 force-pushed the oneof-handle-json branch from 0dd9e2d to 6757437 Compare November 29, 2023 05:41
Oneof values should include json tags to use proper camelCase name and
can be safely omitted when we're handling the interface.
@3v1n0 3v1n0 force-pushed the oneof-handle-json branch from 6757437 to eb117e7 Compare November 29, 2023 05:48
@puellanivis
Copy link

Thank you for your interest into contributing to this project.

Unfortunately this project does not accept GitHub pull requests as the source-of-truth for this project is hosted at https://go.googlesource.com/protobuf. This project page on GitHub is a mirror of that other repository.

If you would like to contribute to this project, please follow the contribution guidelines for instructions on how to send a change. If the change you'd like to make is more substantial or introduces any new features, then it should first be discussed on the issue tracker.

Additionally, be aware that adding JSON tags to oneofs is not compliant with how the JSON mapping standard works. It is generally not recommended to using the standard library encoding/json to convert a protobuf to JSON, precisely because it cannot work in manner that is compliant with the protobuf JSON mapping standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants