-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flurry of dependencies and conflicts brought in with latest protobuf bazel module #19451
Comments
Looking at the module definition, it seems as if this should have been fixed in this PR, which should be in the latest release. |
I can see 29.0 came out 5 days ago, presumably that would contain the fix which was from October? Yet I still see the issue in 29.0.. |
Ah, I see, @shs96c 29.0 did come out 5 days ago, but it's not the very latest, unless I'm misunderstanding github, it's missing 800 or so commits amongst which the fix you mention: v29.0...main |
This should be patched in the v29.1 patch -- please reopen if you are still hitting this! |
I've just upgraded to bazelmod from 28.3 to 29.0 for protobuf and I'm getting these warnings:
These dependencies are somehow being brought in via the
protobuf
module.The concerns I have:
biz.aQute.bnd
Filed as a bug as I cannot really see why all these non-production dependencies or deps that seem unrelated to the task at hand, that are so far behind, would be exposed besides some sort of error during release... almost feels like something test related has leaked into prod by mistake.
I really hope I'm "holding it wrong" and there's a quick fix.
What version of protobuf and what language are you using?
Java
What operating system (Linux, Windows, ...) and version?
Linux/Mac OS M1
What runtime / compiler are you using (e.g., python version or gcc version)
bazel 7 Java 21
As a precaution, I've rolled back to 28.3 but I have no idea what the impact will be. There are so many separate bazel modules required to work with protobufs and grpc that it's often hard to tell exactly what each module is providing.
The text was updated successfully, but these errors were encountered: