Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin_output for _generate_rust_gencode #18255

Closed
wants to merge 2 commits into from

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Sep 11, 2024

Used the python rules as an example to fix this. Bazel now recognizes that the output files have been produced, where before there were build failures regarding the outputs not being produced.

rust/aspects.bzl Outdated Show resolved Hide resolved
@tempoz tempoz force-pushed the tempoz-fix-rust-outputs branch from 2735d60 to fa9d940 Compare November 15, 2024 16:54
@JasonLunn JasonLunn added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed wait for user action labels Nov 17, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Nov 17, 2024
@JasonLunn
Copy link
Contributor

Seeing failures on the Rust tests of the form:

Traceback (most recent call last):
	File "/workspace/rust/aspects.bzl", line 284, column 37, in _rust_cc_proto_aspect_impl
		return _rust_proto_aspect_common(target, ctx, is_upb = False)
	File "/workspace/rust/aspects.bzl", line 321, column 47, in _rust_proto_aspect_common
		(gencode, thunks) = _generate_rust_gencode(
	File "/workspace/rust/aspects.bzl", line 131, column 25, in _generate_rust_gencode
		proto_lang_toolchain.output_files = ctx.bin_dir.path + "/" + proto_root
Error: struct value does not support field assignment

@tempoz
Copy link
Contributor Author

tempoz commented Nov 18, 2024

Sorry, I must have lost track of things and not pushed my local changes; this was a failed intermediate state

@tempoz tempoz force-pushed the tempoz-fix-rust-outputs branch from fa9d940 to dfad229 Compare November 18, 2024 16:40
@tempoz
Copy link
Contributor Author

tempoz commented Nov 18, 2024

Should be corrected now.

@JasonLunn JasonLunn added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed wait for user action labels Nov 18, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants