Skip to content

Commit 9ac1248

Browse files
committed
feat(jira): rename method get_jira_metadata to get_metadata
1 parent fd7a15c commit 9ac1248

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

prowler/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
44
## [v5.12.0] (Prowler UNRELEASED)
55

66
### Added
7-
- Create method get_jira_metadata inside Jira class [(#8630)](https://github.com/prowler-cloud/prowler/pull/8630)
7+
- Get Jira Project's metadata [(#8630)](https://github.com/prowler-cloud/prowler/pull/8630)
88

99

1010
### Changed

prowler/lib/outputs/jira/jira.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ def get_available_issue_types(self, project_key: str = None) -> list[str]:
682682
file=os.path.basename(__file__),
683683
)
684684

685-
def get_jira_metadata(self) -> dict:
685+
def get_metadata(self) -> dict:
686686
"""Get the metadata from Jira
687687
688688
Returns:

tests/lib/outputs/jira/jira_test.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,7 @@ def test_get_projects_and_issue_types_successful(
959959
mock_issue_types_response_2,
960960
]
961961

962-
jira_metadata = self.jira_integration.get_jira_metadata()
962+
jira_metadata = self.jira_integration.get_metadata()
963963

964964
expected_result = {
965965
"PROJ1": {
@@ -994,7 +994,7 @@ def test_get_projects_and_issue_types_successful(
994994
def test_get_projects_and_issue_types_no_projects_found(
995995
self, mock_get, mock_cloud_id, mock_get_access_token
996996
):
997-
"""Test that get_jira_metadata raises JiraNoProjectsError when no projects are found."""
997+
"""Test that get_metadata raises JiraNoProjectsError when no projects are found."""
998998
# To disable vulture
999999
mock_cloud_id = mock_cloud_id
10001000
mock_get_access_token = mock_get_access_token
@@ -1005,7 +1005,7 @@ def test_get_projects_and_issue_types_no_projects_found(
10051005
mock_get.return_value = mock_response
10061006

10071007
with pytest.raises(JiraNoProjectsError):
1008-
self.jira_integration.get_jira_metadata()
1008+
self.jira_integration.get_metadata()
10091009

10101010
@patch.object(Jira, "get_access_token", return_value="valid_access_token")
10111011
@patch.object(
@@ -1015,7 +1015,7 @@ def test_get_projects_and_issue_types_no_projects_found(
10151015
def test_get_projects_and_issue_types_projects_response_error(
10161016
self, mock_get, mock_cloud_id, mock_get_access_token
10171017
):
1018-
"""Test that get_jira_metadata raises JiraGetProjectsError when projects request fails."""
1018+
"""Test that get_metadata raises JiraGetProjectsError when projects request fails."""
10191019
# To disable vulture
10201020
mock_cloud_id = mock_cloud_id
10211021
mock_get_access_token = mock_get_access_token
@@ -1026,7 +1026,7 @@ def test_get_projects_and_issue_types_projects_response_error(
10261026
mock_get.return_value = mock_response
10271027

10281028
with pytest.raises(JiraGetProjectsError):
1029-
self.jira_integration.get_jira_metadata()
1029+
self.jira_integration.get_metadata()
10301030

10311031
@patch.object(Jira, "get_access_token", return_value="valid_access_token")
10321032
@patch.object(
@@ -1036,7 +1036,7 @@ def test_get_projects_and_issue_types_projects_response_error(
10361036
def test_get_projects_and_issue_types_issue_types_response_error(
10371037
self, mock_get, mock_cloud_id, mock_get_access_token
10381038
):
1039-
"""Test that get_jira_metadata raises JiraGetProjectsError when issue types request fails."""
1039+
"""Test that get_metadata raises JiraGetProjectsError when issue types request fails."""
10401040
# To disable vulture
10411041
mock_cloud_id = mock_cloud_id
10421042
mock_get_access_token = mock_get_access_token
@@ -1055,7 +1055,7 @@ def test_get_projects_and_issue_types_issue_types_response_error(
10551055
mock_get.side_effect = [mock_projects_response, mock_issue_types_response]
10561056

10571057
with pytest.raises(JiraGetProjectsError):
1058-
self.jira_integration.get_jira_metadata()
1058+
self.jira_integration.get_metadata()
10591059

10601060
@patch.object(Jira, "get_access_token", return_value="valid_access_token")
10611061
@patch.object(
@@ -1065,7 +1065,7 @@ def test_get_projects_and_issue_types_issue_types_response_error(
10651065
def test_get_projects_and_issue_types_no_project_metadata(
10661066
self, mock_get, mock_cloud_id, mock_get_access_token
10671067
):
1068-
"""Test that get_jira_metadata returns empty issue_types when project metadata is empty."""
1068+
"""Test that get_metadata returns empty issue_types when project metadata is empty."""
10691069
# To disable vulture
10701070
mock_cloud_id = mock_cloud_id
10711071
mock_get_access_token = mock_get_access_token
@@ -1084,7 +1084,7 @@ def test_get_projects_and_issue_types_no_project_metadata(
10841084

10851085
mock_get.side_effect = [mock_projects_response, mock_issue_types_response]
10861086

1087-
projects_and_issue_types = self.jira_integration.get_jira_metadata()
1087+
projects_and_issue_types = self.jira_integration.get_metadata()
10881088

10891089
expected_result = {
10901090
"PROJ1": {
@@ -1103,12 +1103,12 @@ def test_get_projects_and_issue_types_no_project_metadata(
11031103
def test_get_projects_and_issue_types_refresh_token_error(
11041104
self, mock_get_access_token
11051105
):
1106-
"""Test that get_jira_metadata raises JiraRefreshTokenError when refreshing the token fails."""
1106+
"""Test that get_metadata raises JiraRefreshTokenError when refreshing the token fails."""
11071107
# To disable vulture
11081108
mock_get_access_token = mock_get_access_token
11091109

11101110
with pytest.raises(JiraRefreshTokenError):
1111-
self.jira_integration.get_jira_metadata()
1111+
self.jira_integration.get_metadata()
11121112

11131113
@patch.object(Jira, "get_access_token", return_value="valid_access_token")
11141114
@patch.object(
@@ -1118,7 +1118,7 @@ def test_get_projects_and_issue_types_refresh_token_error(
11181118
def test_get_projects_and_issue_types_mixed_scenarios(
11191119
self, mock_get, mock_cloud_id, mock_get_access_token
11201120
):
1121-
"""Test get_jira_metadata with mixed success and empty metadata scenarios."""
1121+
"""Test get_metadata with mixed success and empty metadata scenarios."""
11221122
# To disable vulture
11231123
mock_cloud_id = mock_cloud_id
11241124
mock_get_access_token = mock_get_access_token
@@ -1156,7 +1156,7 @@ def test_get_projects_and_issue_types_mixed_scenarios(
11561156
mock_issue_types_response_2,
11571157
]
11581158

1159-
projects_and_issue_types = self.jira_integration.get_jira_metadata()
1159+
projects_and_issue_types = self.jira_integration.get_metadata()
11601160

11611161
expected_result = {
11621162
"PROJ1": {

0 commit comments

Comments
 (0)