Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Client Support #12991

Open
5 of 20 tasks
rkapka opened this issue Oct 3, 2023 · 0 comments
Open
5 of 20 tasks

Light Client Support #12991

rkapka opened this issue Oct 3, 2023 · 0 comments
Labels
Enhancement New feature or request Light Client

Comments

@rkapka
Copy link
Contributor

rkapka commented Oct 3, 2023

Must have

  • Implement is_better_update
  • Add Capella/Deneb changes from corresponding full-node.md spec files
  • Add SSZ support for Beacon API endpoints
  • Store light client updates in the database (possibly one update per period, but we have to take into account the following:

Also keep in mind, that there may be networks where the sync committee period boundary does not align with the fork schedule, so the database should be flexible enough to support that.

Full nodes SHOULD provide the best derivable LightClientUpdate (according to is_better_update) for each sync committee period covering any epochs in range [max(ALTAIR_FORK_EPOCH, current_epoch - MIN_EPOCHS_FOR_BLOCK_REQUESTS), current_epoch] where current_epoch is defined by the current wall-clock time. Full nodes MAY also provide LightClientUpdate for other sync committee periods.

  • LightClientUpdate are assigned to sync committee periods based on their attested_header.beacon.slot
  • LightClientUpdate are only considered if compute_sync_committee_period_at_slot(update.attested_header.beacon.slot) == compute_sync_committee_period_at_slot(update.signature_slot)
  • Only LightClientUpdate with next_sync_committee as selected by fork choice are provided, regardless of ranking by is_better_update. To uniquely identify a non-finalized sync committee fork, all of period, current_sync_committee and next_sync_committee need to be incorporated, as sync committees may reappear over time.

Nice to have

Cosmetic

  • Stateless function that do not use the blockchain service, such as the ones in /beacon-chain/blockchain/lightclient.go, should be placed under beacon-chain/core. Let's create a new /beacon-chain/core/light-client package and move such functions there.
  • Declare/use protos in v1aplha1 instead of v1/v2
  • Add more solid unit tests to HTTP handlers, as commented here: [2/5] light client http api #12984 (comment)
  • Use t.Run in HTTP handler tests and reduce duplication (for example, save updates to the DB once instead of for every test)
  • Do a final pass and look for code health improvements
@rkapka rkapka added the Cleanup Code health! label Oct 3, 2023
@rkapka rkapka changed the title Move light client code from blockchain to core Light client improvements Nov 16, 2023
@rkapka rkapka changed the title Light client improvements Light Client Support Jul 15, 2024
@rkapka rkapka added Enhancement New feature or request Light Client and removed Cleanup Code health! labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Light Client
Projects
None yet
Development

No branches or pull requests

1 participant