Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server ignores request to gzip data #14593

Open
tmeinlschmidt opened this issue Oct 30, 2024 · 5 comments
Open

server ignores request to gzip data #14593

tmeinlschmidt opened this issue Oct 30, 2024 · 5 comments
Assignees
Labels
API Api related tasks Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed
Milestone

Comments

@tmeinlschmidt
Copy link

Describe the bug

version: beacon-chain:v5.0.4

was checking tcpdump as we had some issues and found following

(GET /eth/v1/beacon/blob_sidecars/10252744?indices=0&indices=1&indices=2&indices=3&indices=4 HTTP/1.1
Host: beacon:7028
User-Agent: Go-http-client/1.1
Accept: application/json
Accept-Encoding: gzip

response

Content-Type: application/json
Vary: Origin
Vary: Origin
Date: Tue, 29 Oct 2024 17:06:42 GMT
Transfer-Encoding: chunked

142720
{"data":[{"index":"0","blob":"0x3e0001fbfc...

so it ignored Accept-Encoding header and sending only plain json. Would be great if beacon can handle this correctly.

Has this worked before in a previous version?

No response

🔬 Minimal Reproduction

No response

Error

No response

Platform(s)

Linux (x86)

What version of Prysm are you running? (Which release)

5.0.4

Anything else relevant (validator index / public key)?

No response

@tmeinlschmidt tmeinlschmidt added the Bug Something isn't working label Oct 30, 2024
@james-prysm james-prysm added API Api related tasks Enhancement New feature or request Help Wanted Extra attention is needed and removed Bug Something isn't working labels Oct 30, 2024
@james-prysm
Copy link
Contributor

I don't believe this is a required feature of https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlobSidecars. Do other clients support this encoding?

@tmeinlschmidt
Copy link
Author

tmeinlschmidt commented Oct 30, 2024

rpcdaemon (as server) and erigon (as client) works just fine and compress data.

request to beacon came from base/ptimism chain

and to be honest, didn't check other endpoints from beacon, assuming it's a general issue when returning data via http

@prestonvanloon prestonvanloon added this to the v6 milestone Oct 30, 2024
@prestonvanloon prestonvanloon added the Good First Issue Good for newcomers label Oct 30, 2024
@prestonvanloon
Copy link
Member

Seems like a reasonable request to have the beacon chain return gzip encoded payloads when requested for the beacon API.

@rkapka rkapka self-assigned this Nov 1, 2024
@rose2221
Copy link

i'd like to work on this issue

@rkapka
Copy link
Contributor

rkapka commented Dec 20, 2024

Thanks @rose2221 , I assigned it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants