Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set gas limit through validator client #14721

Closed
terencechain opened this issue Dec 13, 2024 · 2 comments
Closed

Cannot set gas limit through validator client #14721

terencechain opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@terencechain
Copy link
Member

Setting the gas limit through the validator client is broken. Even if someone sets the gas limit on the validator client, it always uses the default gas limit from the config.

  1. Starting from the beginning, the validator client starts up by registering proposer settings.
    Screenshot 2024-12-12 at 11 05 43 AM

  2. The proposer settings service attempts to load the proposer settings file.

Screenshot 2024-12-12 at 9 40 44 PM
  1. If the setting is a file, it loads the settings from the file.
Screenshot 2024-12-12 at 9 41 08 PM
  1. Before it loads the settings from the file, it also loads the default configs. For some reason, it overrides gasLimitOnly with the default gas limit config.
Screenshot 2024-12-12 at 9 41 48 PM
  1. Then it passes the default gas limit config to the process builder config.
Screenshot 2024-12-12 at 9 42 05 PM
  1. Finally, here is the bug. If gasLimitOnly is set, it uses the default config to override the gas limit from the proposer settings file.
Screenshot 2024-12-12 at 9 42 17 PM
@james-prysm james-prysm self-assigned this Dec 30, 2024
@james-prysm james-prysm added the Bug Something isn't working label Dec 30, 2024
@james-prysm
Copy link
Contributor

after investigating i believe it is working as intended.

the fee recipient flag and gas limit flags will override the config file.

if the file is provided as is ( without the gas limit flag) the loader correctly loads each different gas limit
if the file is provided with the gas limit flag, the gas limit flag overrides all values from the file ( as intended )

more testing can be conducted to insure absolute confidence,
next steps could be improved documentation and added logs including warning logs

@terencechain
Copy link
Member Author

Closing this. Reason outlined here: #14723 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants