You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting the gas limit through the validator client is broken. Even if someone sets the gas limit on the validator client, it always uses the default gas limit from the config.
Starting from the beginning, the validator client starts up by registering proposer settings.
The proposer settings service attempts to load the proposer settings file.
If the setting is a file, it loads the settings from the file.
Before it loads the settings from the file, it also loads the default configs. For some reason, it overrides gasLimitOnly with the default gas limit config.
Then it passes the default gas limit config to the process builder config.
Finally, here is the bug. If gasLimitOnly is set, it uses the default config to override the gas limit from the proposer settings file.
The text was updated successfully, but these errors were encountered:
after investigating i believe it is working as intended.
the fee recipient flag and gas limit flags will override the config file.
if the file is provided as is ( without the gas limit flag) the loader correctly loads each different gas limit
if the file is provided with the gas limit flag, the gas limit flag overrides all values from the file ( as intended )
more testing can be conducted to insure absolute confidence,
next steps could be improved documentation and added logs including warning logs
Setting the gas limit through the validator client is broken. Even if someone sets the gas limit on the validator client, it always uses the default gas limit from the config.
Starting from the beginning, the validator client starts up by registering proposer settings.
The proposer settings service attempts to load the proposer settings file.
gasLimitOnly
with the default gas limit config.gasLimitOnly
is set, it uses the default config to override the gas limit from the proposer settings file.The text was updated successfully, but these errors were encountered: