phpactorgh-2755: carbon performance (phpactor#2768)

- Limit number of members that are rendered
- Fix offset info to specify path for text document

Author: dantleech

CHANGELOG.md

@@ -6,6 +6,8 @@ Changelog
 Improvements:
 
   - Tolerate code action provider failures #2761 @dantleech
+  - Limit number of methods that are documented on classes to improve
+    completion/resolve performance for large classes #2768 @dantleech
 
 ## 2024-11-05
 

lib/Extension/LanguageServerCompletion/Tests/Integration/MarkdownObjectRendererTest.php

@@ -193,6 +193,24 @@ public function foobar(): void {}
             'class_reflection3.md',
         ];
 
+        yield 'too many members' => [
+            '',
+            function (Reflector $reflector) {
+                return $this->reflectClassesIn(
+                    $reflector,
+                    sprintf(
+                        '<?php class SomeClass { %s }',
+                        implode(' ', array_map(
+                            fn (int $number) => sprintf('public function fun%s():void{}', $number),
+                            range(1, 53),
+                        ))
+                    ),
+                )->get('SomeClass');
+            },
+            'class_reflection_too_many_members.md',
+            false,
+        ];
+
         yield 'final class' => [
             '',
             function (Reflector $reflector) {

lib/Extension/LanguageServerCompletion/Tests/Integration/expected/class_reflection3.md

@@ -1,5 +1,5 @@
 class SomeClass {
-    public function foobar(): void
     public const FOOBAR = "bar";
     public $foo;
+    public function foobar(): void
 }

lib/Extension/LanguageServerCompletion/Tests/Integration/expected/class_reflection_too_many_members.md

@@ -0,0 +1,53 @@
+class SomeClass {
+    public function fun1(): void
+    public function fun2(): void
+    public function fun3(): void
+    public function fun4(): void
+    public function fun5(): void
+    public function fun6(): void
+    public function fun7(): void
+    public function fun8(): void
+    public function fun9(): void
+    public function fun10(): void
+    public function fun11(): void
+    public function fun12(): void
+    public function fun13(): void
+    public function fun14(): void
+    public function fun15(): void
+    public function fun16(): void
+    public function fun17(): void
+    public function fun18(): void
+    public function fun19(): void
+    public function fun20(): void
+    public function fun21(): void
+    public function fun22(): void
+    public function fun23(): void
+    public function fun24(): void
+    public function fun25(): void
+    public function fun26(): void
+    public function fun27(): void
+    public function fun28(): void
+    public function fun29(): void
+    public function fun30(): void
+    public function fun31(): void
+    public function fun32(): void
+    public function fun33(): void
+    public function fun34(): void
+    public function fun35(): void
+    public function fun36(): void
+    public function fun37(): void
+    public function fun38(): void
+    public function fun39(): void
+    public function fun40(): void
+    public function fun41(): void
+    public function fun42(): void
+    public function fun43(): void
+    public function fun44(): void
+    public function fun45(): void
+    public function fun46(): void
+    public function fun47(): void
+    public function fun48(): void
+    public function fun49(): void
+    public function fun50(): void
+    // and 3 more...
+}

lib/Extension/LanguageServerCompletion/Tests/Integration/expected/method_variadic.md

@@ -1 +1 @@
-public function foo(Foobar ...$foo)
+public function foo(Foobar ...$foo)

lib/Extension/LanguageServerCompletion/Tests/Integration/expected/method_variadic_no_type.md

@@ -1 +1 @@
-public function foo(<missing> ...$foo)
+public function foo(<missing> ...$foo)

lib/Extension/WorseReflectionExtra/Application/OffsetInfo.php

@@ -8,6 +8,8 @@
 use Phpactor\Extension\Core\Application\Helper\ClassFileNormalizer;
 use Phpactor\Extension\Core\Application\Helper\FilesystemHelper;
 use Phpactor\WorseReflection\TypeUtil;
+use Symfony\Component\Filesystem\Path;
+use function Safe\getcwd;
 
 final class OffsetInfo
 {
@@ -26,7 +28,7 @@ public function infoForOffset(string $sourcePath, int $offset, bool $showFrame =
         $result = $this->reflector->reflectOffset(
             TextDocumentBuilder::create(
                 $this->filesystemHelper->contentsFromFileOrStdin($sourcePath)
-            )->build(),
+            )->uri(Path::makeAbsolute($sourcePath, getcwd()))->build(),
             ByteOffset::fromInt($offset)
         );
 

templates/help/markdown/Phpactor/WorseReflection/Core/Reflection/Collection/ReflectionMemberCollection.twig

@@ -0,0 +1,9 @@
+{# classes such as Carbon have 1k members and rendering documentation for each
+   is both time consuming and pointless - limit number of displayed members to finite amount #}
+{% set members = object.byVisibilities(["public"]) %}
+{% for index, member in  members|slice(0,50) -%}
+{{ '    ' ~ render(member) }}
+{% endfor -%}
+{% if members|length > 50 %}
+    // and {{ members|length - 50 }} more...
+{% endif %}

templates/help/markdown/Phpactor/WorseReflection/Core/Reflection/ReflectionClass.twig

@@ -3,13 +3,5 @@
 {% if object.interfaces.count %} implements {% for interface in object.interfaces -%}
     {{ interface.name.short }}{% if not loop.last %}, {% endif %}
     {%- endfor %}{% endif %} {
-{% for member in object.methods.byVisibilities(["public"]) -%}
-{{ '    ' ~ render(member) }}
-{% endfor -%}
-{% for member in object.constants.byVisibilities(["public"]) -%}
-{{ '    ' ~ render(member) }}
-{% endfor -%}
-{% for member in object.properties.byVisibilities(["public"]) -%}
-{{ '    ' ~ render(member) }}
-{% endfor -%}
+{{ render(object.members) -}}
 }