Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error buffer optional #17

Open
MichaelXavier opened this issue Oct 17, 2018 · 0 comments
Open

Make error buffer optional #17

MichaelXavier opened this issue Oct 17, 2018 · 0 comments

Comments

@MichaelXavier
Copy link
Contributor

Hi! I've been using and enjoying dhall-mode but I was wondering if it would be possible to add an option that when toggled on would suppress the dhall error buffer. It replaces one of the existing buffers if you have multiple buffers per window and it can be kind of disruptive to your workflow. In the mean time I'm planning on wrangling the buffer with popwin so that it always creates a new buffer that can be easily dismissed, e.g. ("*dhall errors*" :height 10 :noselect t :stick t :tail nil)

MichaelXavier added a commit to MichaelXavier/dhall-mode that referenced this issue Oct 17, 2018
This is for psibi#17. It looks like there was already some intent expressed
in the code to not run the after change hook if
`dhall-use-header-line` was disabled, but it wasn't enacted when the
hook showed up. At first I thought I might just not register the hook
if `dhall-use-header-line` was disabled, but that would create
confusing behavior if the user live-configured their emacs to enable
that. So the hook will always fire but it will be a no-op if the type
won't be used.

Also for good measure I moved the timeout into an option so folks who
are having performance problems but don't want to completely abandon
buffer type can make a tradeoff in feedback cycle time for
responsiveness.

The motivation behind this is that on moderately large files, running
the type check every second makes any modification to the buffer
completely lock up. I'm happy to turn off the buffer type feature keep
the rest of the functionality like auto-reformatting and syntax
highlighting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant