Commit dfbc118
Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (pytorch#20907)
Summary:
After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.
Root cause: MODEL_CONVERTER_LIB_DIR was set to
$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.
Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.
Impact: −160 SKIPPING tests
Reviewed By: rascani
Differential Revision: D1118194841 parent 39f4355 commit dfbc118
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| |||
0 commit comments