Skip to content

Commit dfbc118

Browse files
psiddhfacebook-github-bot
authored andcommitted
Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (pytorch#20907)
Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
1 parent 39f4355 commit dfbc118

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

backends/arm/test/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def define_arm_tests():
102102
if not runtime.is_oss and _ENABLE_VGF:
103103
test_env.update({
104104
"MODEL_CONVERTER_PATH": "$(location fbsource//third-party/pypi/ai-ml-sdk-model-converter/0.9.0:model-converter-bin)",
105-
"MODEL_CONVERTER_LIB_DIR": "$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64",
105+
"MODEL_CONVERTER_LIB_DIR": "$(location fbsource//third-party/nvidia-nsight-systems:host-linux-x64-libs)",
106106
"LAVAPIPE_LIB_PATH": "$(location fbsource//third-party/mesa:vulkan_lvp)",
107107
"EMULATION_LAYER_TENSOR_SO": "$(location fbsource//third-party/arm-ml-emulation-layer/v0.9.0/src:libVkLayer_Tensor)",
108108
"EMULATION_LAYER_GRAPH_SO": "$(location fbsource//third-party/arm-ml-emulation-layer/v0.9.0/src:libVkLayer_Graph)",

0 commit comments

Comments
 (0)