Support building on plasma 5.26.90+ #191
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested and it works! |
|
Yes, working here as well, but is it really needed to bump the requirements in cmake to plasma 5.27 beta? Can't this method be implemented and still compile against the previous dependencies? |
Is there a way to check the current kdecoration version in pre-processor? |
|
@chermnyx Thank you! Worked here as well: |
DiabeticCrab
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Works as expected with Plasma 5.27.0, KDE Frameworks 5.103 and QT 5.15.8 on Gentoo x86_64.
As a side note, these changes break backwards compatibility with older KDE versions - for me, that's a non-issue but maybe not everyone agrees with that.
@chermnyx Thank you very much for your effort!
artfox3
approved these changes
Feb 16, 2023
Xeo23
approved these changes
Feb 19, 2023
|
hi, cant build on plasma 5.27 |
|
I could build it on Plasma 5.27, and works as it used to: |
It requires plasma 5.27 (the new version of the kdecorations package). I don't know how to conditionally exclude part of the code depending on this lib's version for it to be compatible with the older versions |
|
@chermnyx could you test the plasmashell itself instead of kdecoration, i don't know if this is useful but you can get the plasmashell version using |
|
I'm having issues to compile it in plasma 5.27 as well, the issue is the same @Edip1 mentioned here, and the error is this: It seems that PreviewClient is abstract so it can't be instantiated, I don't know if/how that can be solved without modifying code. Operating System: KDE neon 5.27 (Ubuntu 22.04) |
|
Hi @xavier83ar, How did you apply the changes? Did you copy and paste from https://github.com/psifidotos/applet-window-buttons/pull/191/files? Telling because I did that myself and this introduced compiling errors. I think there are some weird invisible characters that are added when using copy and paste from GitHub code directly. When I just typed manually these lines myself, the code compiled properly. Please note that my system is the same as yours: up-to-date KDE neon. |
|
Mm... nop, but you made me realize what my mistake was... 🤦🏼♂️ I've cloned the repo and started trying to build right away without switching to the right branch!! Thank you! |
do you mean the fork? |
|
The following steps resulted in success for me (5.26.90/5.27) in both KDE neon and Sparky KDE:
|
yes I cloned this fork, but when you clone a repo you get the default branch which is master in this case, so I was trying to compile a branch that didn't include the fix, after checking out the right branch, I could compile it without any issues. |
|
Can somebody merge this? I know psifidotos is not working on latte-dock anymore. |
Xeo23
approved these changes
Mar 26, 2023
HTOgit
approved these changes
Apr 2, 2023
Louis-J
reviewed
Apr 3, 2023
| @@ -8,7 +8,7 @@ set(EMAIL "[email protected]") | |||
|
|
|||
| set(QT_MIN_VERSION "5.15.0") | |||
| set(KF5_MIN_VERSION "5.81.0") | |||
| set(KDECORATION2_MIN_VERSION "5.24.0") | |||
| set(KDECORATION2_MIN_VERSION "5.26.90") | |||
There was a problem hiding this comment.
i think it's ok to use 5.24.0 and use QString windowClass() const; instead of QString windowClass() const **override**;, and then it can support both in 5.24 and 5.26.
He need to transfer the ownership of the repository to the community or give permissions so another persons could merge PR, make tags, and do releases... |
|
Building works, but I get this applet error:
MX Linux 23.1 |
rickysarraf
added a commit
to rickysarraf/applet-window-buttons
that referenced
this pull request
Apr 9, 2024
|
Hello @MajorTomDE ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190 in a naive way.
After changes in libkdecoration private api the applet's libdecoration should implement
PreviewClient::windowClass()method.Instead of getting window_class of the real window the code returns placeholder values like in
windowId()anddecorationId()methods.