Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Graphs and Charts #46

Open
Ennazus opened this issue Apr 14, 2020 · 3 comments
Open

Improvements in Graphs and Charts #46

Ennazus opened this issue Apr 14, 2020 · 3 comments
Assignees

Comments

@Ennazus
Copy link
Member

Ennazus commented Apr 14, 2020

In some of the graphics the y-scale should adjust to show the max value (for example, the mode group)
Having in mind that the app will be used externally, I would imagine people might screenshot the graphics. Thus, it will be great if the graphics would include a title, x-axis name, data source, etc.
Is there a way to have a scrolling bar to show the full chart if the window size doesn’t allow to show a full graphics? Here is an example:

@cyyllam
Copy link
Contributor

cyyllam commented Apr 22, 2020

@polinabutrina Aesthetic-wise, I would avoid a scrolling bar to show the full chart.

  • It doesn't look good imho and defeats the purpose of screenshots.
  • I'd like to reduce the amount of scrolling for the user.
  • Also, with the option of downloading the data, users can create their own graphs if they wish.

Otherwise, I'll work on including title, xaxis name and data source.

@Ennazus
Copy link
Member Author

Ennazus commented Apr 22, 2020

This idea came from Polina's review, so you might want to touch base with her to clarify if there's anything you'd like her to review about the improvement.

@cyyllam
Copy link
Contributor

cyyllam commented May 5, 2020

  • Added Title (includes 'Regional results' or 'Seattle results')

  • Added source caption on lower right

  • I didn't add the max y-value as another tick label on the plot (unless there's more push for it later). Users have the option of hovering for detail or they can sort the table. Might not be necessary to double-down on this if there are other ways of finding what the range of values is.

  • what might get hidden in the plot is all the legend elements, but users can hover over the legend and use mouse wheel to scroll to bottom. Additionally, user can also hover over the plot and click on 'download plot as png' option and the downloaded image will re-configure to show all legend elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants