Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Factor out all sub-forms into their own React components #61

Open
6 tasks
hoechenberger opened this issue Sep 29, 2019 · 0 comments
Open
6 tasks

Factor out all sub-forms into their own React components #61

hoechenberger opened this issue Sep 29, 2019 · 0 comments

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Sep 29, 2019

Already made some progress in #57, #60, but the following forms still need work

  • reference move
  • fill
  • empty
  • bubble cycle
  • rinse
  • (potentially the Connect / Disconnect button together with the configuration selection bits)

These were all skipped / postponed so far because they use modals, whose state (opened / closed) is handled globally via PumpForm's state.modal. These states should probably be moved into their respective new (factored-out) components directly.

The goal is to break the huge project down into smaller bits that are easier to maintain.

@hoechenberger hoechenberger added this to the 2019.2 milestone Sep 29, 2019
@hoechenberger hoechenberger modified the milestones: 2019.2, future Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant