Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add more "Approve" buttons #1330

Open
stevejburge opened this issue Sep 13, 2024 · 5 comments
Open

Can we add more "Approve" buttons #1330

stevejburge opened this issue Sep 13, 2024 · 5 comments

Comments

@stevejburge
Copy link
Member

stevejburge commented Sep 13, 2024

Can we give users more ways to approve a revision?

In the admin bar:
Screenshot 2024-09-13 at 10 22 17 AM

On the Revisions screen:
Screenshot 2024-09-13 at 10 22 09 AM

@stevejburge stevejburge added this to the 3.6.0: Revisions Statuses milestone Sep 13, 2024
@agapetry
Copy link
Contributor

@stevejburge "Publish Now" is already an Approve button in the top bar.

@stevejburge
Copy link
Member Author

Thanks @agapetry. Is that a little different? "Publish Now" means publish right now. "Approve" means approve for future publication?

@agapetry
Copy link
Contributor

Approve is the more general term, meaning either publish it now or schedule it, depending on the stored (requested) publication date. It is used in this general sense in the bulk edit function, so that selected revisions will be either published or scheduled:

image

If you instead apply the bulk action of "Publish", that will cause all selected revisions to be published immediately, regardless of their stored date or scheduling status.

If the stored publication date is not future, there is no distinction between "Approve" and "Publish." In theory, the plugin could implement an "Approved" status as an intermediate condition between Submitted Revision and Published Revision, but that would require some retraining and likely support calls because "Approve" has never before meant that to this plugin.

@agapetry
Copy link
Contributor

There is also a layout consideration. For many browser scenarios, adding another row action would force all the rows in the Revision Queue table to be taller by one row. Is that worth the dubious convenience of being able to approve a revision sight unseen?

image

@stevejburge
Copy link
Member Author

Thanks @agapetry. On the frontend, should we change "Publish Now" to "Approve"?

I'm OK with keeping the button off the admin row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants