Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch-down event should not select date (and related issues) #40

Open
getaaron opened this issue Sep 9, 2013 · 2 comments
Open

Touch-down event should not select date (and related issues) #40

getaaron opened this issue Sep 9, 2013 · 2 comments

Comments

@getaaron
Copy link

getaaron commented Sep 9, 2013

In the current implementation, dates are selected on touch down, not touch up. This feels awkward, and does not match the native iOS calendar app.

This can be partially resolved by modifying TSQCalendarRowCell on lines #59 and #90 to use UIControlEventTouchUpInside instead of UIControlEventTouchDown. However, the following issues still remain:

  • The cells still capture the touch event, so the user can't scroll if he holds his finger too long
  • There is no hit state (like a light gray when a cell is highlighted but not selected)

I don't know the code base well enough to resolve those other issues without reading through everything. I'm happy to put some work into fixing this if someone can point me in the right direction. (I just opened this project for the first time today.)

For comparison, note that the similar project MNCalendarView doesn't have these issues, although that project is lacking many things available in this one.

@randomstep
Copy link

Ah hah! I suspect this puts a finger (pun intended) on why the calendar feels so wrong in our usage. I'll play with it and see how difficult it might be to resolve some of these issues.

I'm curious what design considerations lead to the choice of using TouchDown instead of Up?

@Soryu
Copy link

Soryu commented Sep 11, 2013

@getaaron probably just add _tableView.canCancelContentTouches = YES; in TSQCalendarView.m when the tableView is initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants