Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-next] Renaming a file in the tree-view makes the file lose the name #1145

Open
5 tasks done
mauricioszabo opened this issue Nov 25, 2024 · 1 comment
Open
5 tasks done
Labels
bug Something isn't working pulsar-next Related to the version of Pulsar that runs on the latest Electron

Comments

@mauricioszabo
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

In newest electron branch, renaming an open file in tree-view causes weird behavior: the file in the editor gets the name untitled, and can't be saved (it'll cause an exception).

If I rename the file outside the editor, it disappears from tree-view, and it'll not change the file in the editor (but it'll stay in the editor, as unsaved, with the old name).

Pulsar version

1.122.2024112215 (new Electron branch)

Which OS does this happen on?

🐧 Debian based (Linux Mint, Ubuntu, etc.)

OS details

22.04

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

  1. mkdir /tmp/something
  2. touch /tmp/something/file.py
  3. pulsar /tmp/something
  4. Open file.py, add some contents, and save
  5. Rename file.py to afile.py with the tree-view

In this case, the file in the editor will be called untitled, lose all syntax highlight, and trying to save it will cause an ENOENT exception (visible only at the devtools)

OR, case 2:

  1. Repeat steps 1-4
  2. In a terminal, mv /tmp/something/file.py /tmp/something/other.py

In this case, the file in the editor will stay as file.py, and it'll disappear from the tree-view (and other.py won't also appear at the tree-view).

In the editor, file.py will be marked as modified, and saving it will create the file.py again.

Additional Information:

No response

@mauricioszabo mauricioszabo added bug Something isn't working pulsar-next Related to the version of Pulsar that runs on the latest Electron labels Nov 25, 2024
@savetheclocktower savetheclocktower changed the title [newest-electron] - renaming a file in the tree-view makes the file lose the name [pulsar-next] Renaming a file in the tree-view makes the file lose the name Nov 28, 2024
@savetheclocktower
Copy link
Contributor

I believe I've fixed this in caf9795, but I'll keep this ticket open until I get confirmation from @mauricioszabo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pulsar-next Related to the version of Pulsar that runs on the latest Electron
Projects
None yet
Development

No branches or pull requests

2 participants