Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer in update mode does not update path on Windows #1157

Open
5 tasks done
Simple-ID opened this issue Dec 6, 2024 · 1 comment
Open
5 tasks done

Windows Installer in update mode does not update path on Windows #1157

Simple-ID opened this issue Dec 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Simple-ID
Copy link

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Hi, I performed a full rerun of the steps this morning to confirm the bug on my machine. The installer does not update the path if a current installation already exists.

Pulsar version

Windows.Pulsar.Setup.1.123.0.exe

Which OS does this happen on?

🪟 Windows

OS details

11 latest

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

  1. Perform a fresh installation without modifying the path (no checkboxes selected).
  2. Reinstall without uninstalling first, this time selecting the option to modify the path.

Additional Information:

I can confirm that the path is added correctly during a fresh installation when the respective option is selected.
With further testing, I can also confirm that the path is removed as expected during uninstallation.
The Pulsar UI indicates that rerunning the installer should be sufficient to update the path.
screenshot
screenshot2

@Simple-ID Simple-ID added the bug Something isn't working label Dec 6, 2024
@confused-Techie
Copy link
Member

Thanks a ton for contributing and creating this issue.
I'll have to go ahead and look into this, but yeah within the NSIS code there shouldn't be much of a difference in these scenarios, but hopefully some more testing can help us see what's going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants