Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-next] DepracationWarning of src/task.js #1236

Open
3 of 5 tasks
asiloisad opened this issue Feb 28, 2025 · 1 comment
Open
3 of 5 tasks

[pulsar-next] DepracationWarning of src/task.js #1236

asiloisad opened this issue Feb 28, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@asiloisad
Copy link
Contributor

asiloisad commented Feb 28, 2025

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

It only spammed my console sometimes, I do not know how to trigger it.

Image

Pulsar version

1.124.2025022507-next

Which OS does this happen on?

🪟 Windows

OS details

10

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

Don't know.

Additional Information:

No response

@asiloisad asiloisad added the bug Something isn't working label Feb 28, 2025
@savetheclocktower
Copy link
Contributor

Sigh.

A transitive dependency called isbinaryfile is used by scandal, our library for doing project-wide token searching. It uses [email protected]. That version’s package.json defines a main of ./lib/index.js — a path that does not exist in the package! — so Node complains; but the package still loads properly because there's an index.js at its root, so the default handling logic kicks in. So it complains loudly but ends up doing the right thing.

This never got fixed in the 2.X.X releases, so fixing this would involve upgrading to isbinaryfile@^3. That's certainly doable, but involves an API change. That means we'd have to change scandal itself, and we'd probably want to convert it to JavaScript if we touched it. So it's not likely to get fixed in the short term.

A quick (but hacky) fix would be to filter out any log lines that mention it in src/task.js. I'd do this as a stopgap if it were truly a problem, but I doubt it's worth it.

I'm surprised I've never gotten this log spam. (Maybe I've just never noticed it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants