Skip to content

Commit 4aa919e

Browse files
committedJul 5, 2017
Add comments to build script and clean up main task definition.
1 parent 1975eaa commit 4aa919e

File tree

1 file changed

+25
-11
lines changed

1 file changed

+25
-11
lines changed
 

‎gulpfile.babel.js

+25-11
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ import server from 'browser-sync'
4040
import handlebars from 'handlebars'
4141
import gulpHandlebars from 'gulp-handlebars-html'
4242

43+
/*
44+
* SETUP SCRIPT RUNTIME ENVIRONMENT
45+
*/
46+
4347
// parse program commands
4448
commander.version(pkg.version).option('--silent').parse(process.argv)
4549

@@ -97,16 +101,21 @@ const paths = {
97101
* @public
98102
*/
99103
const start = gulp.series(
100-
function startSpinner(done) {
101-
spinner.print(' ')
102-
spinner.start('Start development server...')
103-
done()
104-
},
104+
logStart,
105105
gulp.parallel(gulp.series(downloadOpenUI5, buildOpenUI5), clean),
106106
gulp.parallel(entry, assets, scripts, styles),
107107
logStats,
108108
watch
109109
)
110+
111+
// log start message and start spinner
112+
function logStart(done) {
113+
spinner.print(' ')
114+
spinner.start('Start development server...')
115+
done()
116+
}
117+
118+
// log start statistics and stop spinner
110119
function logStats(done) {
111120
const sSourceID = pkg.ui5.src
112121
const oSource = pkg.ui5.srcLinks[sSourceID]
@@ -142,17 +151,22 @@ export default start
142151
* @public
143152
*/
144153
const build = gulp.series(
145-
function startSpinner(done) {
146-
spinner.print(' ')
147-
spinner.start('Build start...')
148-
done()
149-
},
154+
logStartDist,
150155
gulp.parallel(gulp.series(downloadOpenUI5, buildOpenUI5), cleanDist),
151156
gulp.parallel(entryDist, assetsDist, scriptsDist, stylesDist),
152157
ui5preloads,
153158
ui5cacheBust,
154159
logStatsDist
155160
)
161+
162+
// log start build message and start spinner
163+
function logStartDist(done) {
164+
spinner.print(' ')
165+
spinner.start('Build start...')
166+
done()
167+
}
168+
169+
// log build statistics and stop spinner
156170
function logStatsDist(done) {
157171
const sSourceID = pkg.ui5.src
158172
const oSource = pkg.ui5.srcLinks[sSourceID]
@@ -642,7 +656,7 @@ function ui5preloads() {
642656
* ----------------------------------------------------------- */
643657

644658
// [production build]
645-
function ui5cacheBust(done) {
659+
function ui5cacheBust() {
646660
// update spinner state
647661
spinner.text = 'Run cache buster...'
648662

0 commit comments

Comments
 (0)
Please sign in to comment.