Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement ORS method. #68

Open
diakodarian opened this issue Nov 16, 2018 · 0 comments
Open

Re-implement ORS method. #68

diakodarian opened this issue Nov 16, 2018 · 0 comments
Assignees
@diakodarian
Labels
enhancement Request new functionality

Comments

@diakodarian
Copy link
Contributor

A properly implemented ORS should in theory be much faster than the standard rejection sampler. This wasn't the case with the previous implementation of ORS. That ORS is faster than RS has already been observed in the python version of the code, and most probably will make the injection process much more efficient.
@diakodarian diakodarian self-assigned this Nov 16, 2018
@diakodarian diakodarian added the enhancement Request new functionality label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diakodarian diakodarian

Labels
enhancement Request new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diakodarian