Merge pull request #820 from puppetlabs/GH-819-permission_denied_from_mkdir

Fix permission denied issue introduced in v4.2.0

Author: david22swan

lib/puppet/provider/docker_compose/ruby.rb

@@ -14,8 +14,7 @@
   end
 
   has_command(:docker_compose, command(:dockercompose)) do
-    Dir.mkdir('/tmp_docker') unless Dir.exist?('/tmp_docker')
-    ENV.store('TMPDIR', '/tmp_docker')
+    environment(HOME: '/root')
   end
 
   def exists?

spec/classes/init_spec.rb

@@ -196,12 +196,6 @@
               }
             else
               it {
-                # Stub /tmp_docker dir to prevent shelling out during spec test
-                allow(Dir).to receive(:exist?).and_wrap_original do |original_method, a|
-                  original_method.call(a)
-                end
-                allow(Dir).to receive(:exist?).with('/tmp_docker').and_return(true)
-
                 is_expected.to contain_class('docker::repos').that_comes_before('Class[docker::install]')
                 is_expected.to contain_class('docker::install').that_comes_before('Class[docker::config]')
                 is_expected.to contain_class('docker::config').that_comes_before('Class[docker::service]')

spec/defines/registry_spec.rb

@@ -2,15 +2,6 @@
 
 require 'spec_helper'
 
-# Stub /tmp_docker dir to prevent shelling out during spec test
-class Dir
-  class << self
-    def exist?(var)
-      return true if var == '/tmp_docker'
-    end
-  end
-end
-
 tests = {
   'with ensure => absent' => {
     'ensure' => 'absent',

spec/unit/lib/puppet/type/docker_compose_spec.rb

@@ -2,15 +2,6 @@
 
 require 'spec_helper'
 
-# Stub /tmp_docker dir to prevent shelling out during spec test
-class Dir
-  class << self
-    def exist?(var)
-      return true if var == '/tmp_docker'
-    end
-  end
-end
-
 compose = Puppet::Type.type(:docker_compose)
 
 describe compose do